From 580dbeba7af47c480f094d1e6aa9195123338a6d Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Mon, 26 Jun 2017 21:44:11 -0700 Subject: [PATCH] resourceloader: Add @covers for stripBom and makeModuleResponse tests Change-Id: Ie32178cdd03a79a0ab871122acf081c65e5a9f4d --- .../includes/resourceloader/ResourceLoaderFileModuleTest.php | 3 +++ tests/phpunit/includes/resourceloader/ResourceLoaderTest.php | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderFileModuleTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderFileModuleTest.php index 9a03d3ca7c..9750ea49de 100644 --- a/tests/phpunit/includes/resourceloader/ResourceLoaderFileModuleTest.php +++ b/tests/phpunit/includes/resourceloader/ResourceLoaderFileModuleTest.php @@ -288,6 +288,9 @@ class ResourceLoaderFileModuleTest extends ResourceLoaderTestCase { } } + /** + * @covers ResourceLoaderFileModule::stripBom + */ public function testBomConcatenation() { $basePath = __DIR__ . '/../../data/css'; $testModule = new ResourceLoaderFileModule( [ diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderTest.php index 79d0784c27..c9d103defe 100644 --- a/tests/phpunit/includes/resourceloader/ResourceLoaderTest.php +++ b/tests/phpunit/includes/resourceloader/ResourceLoaderTest.php @@ -607,6 +607,8 @@ mw.example(); * Verify that when building module content in a load.php response, * an exception from one module will not break script output from * other modules. + * + * @covers ResourceLoader::makeModuleResponse */ public function testMakeModuleResponseError() { $modules = [ @@ -643,6 +645,8 @@ mw.example(); * Verify that when building the startup module response, * an exception from one module class will not break the entire * startup module response. See T152266. + * + * @covers ResourceLoader::makeModuleResponse */ public function testMakeModuleResponseStartupError() { $rl = new EmptyResourceLoader(); -- 2.20.1