From 540d8dafeb3017236f7bdf09137653f19992b806 Mon Sep 17 00:00:00 2001
From: Siebrand Mazeland <s.mazeland@xs4all.nl>
Date: Sun, 17 Nov 2013 22:49:03 +0100
Subject: [PATCH] Declare visibility on class properties of LocalisationCache

Mark all private, except the one that's being used in subclass. Checked
core and extension for direct uses. None found.

Change-Id: If73d65ca094ff56deb19d3b6f3ef99892654726d
---
 includes/cache/LocalisationCache.php | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/includes/cache/LocalisationCache.php b/includes/cache/LocalisationCache.php
index 3838c9bca4..2c9d8ae364 100644
--- a/includes/cache/LocalisationCache.php
+++ b/includes/cache/LocalisationCache.php
@@ -36,19 +36,19 @@ define( 'MW_LC_VERSION', 2 );
  */
 class LocalisationCache {
 	/** Configuration associative array */
-	var $conf;
+	private $conf;
 
 	/**
 	 * True if recaching should only be done on an explicit call to recache().
 	 * Setting this reduces the overhead of cache freshness checking, which
 	 * requires doing a stat() for every extension i18n file.
 	 */
-	var $manualRecache = false;
+	private $manualRecache = false;
 
 	/**
 	 * True to treat all files as expired until they are regenerated by this object.
 	 */
-	var $forceRecache = false;
+	private $forceRecache = false;
 
 	/**
 	 * The cache data. 3-d array, where the first key is the language code,
@@ -56,14 +56,14 @@ class LocalisationCache {
 	 * an item specific subkey index. Some items are not arrays and so for those
 	 * items, there are no subkeys.
 	 */
-	var $data = array();
+	protected $data = array();
 
 	/**
 	 * The persistent store object. An instance of LCStore.
 	 *
 	 * @var LCStore
 	 */
-	var $store;
+	private $store;
 
 	/**
 	 * A 2-d associative array, code/key, where presence indicates that the item
@@ -72,32 +72,32 @@ class LocalisationCache {
 	 * For split items, if set, this indicates that all of the subitems have been
 	 * loaded.
 	 */
-	var $loadedItems = array();
+	private $loadedItems = array();
 
 	/**
 	 * A 3-d associative array, code/key/subkey, where presence indicates that
 	 * the subitem is loaded. Only used for the split items, i.e. messages.
 	 */
-	var $loadedSubitems = array();
+	private $loadedSubitems = array();
 
 	/**
 	 * An array where presence of a key indicates that that language has been
 	 * initialised. Initialisation includes checking for cache expiry and doing
 	 * any necessary updates.
 	 */
-	var $initialisedLangs = array();
+	private $initialisedLangs = array();
 
 	/**
 	 * An array mapping non-existent pseudo-languages to fallback languages. This
 	 * is filled by initShallowFallback() when data is requested from a language
 	 * that lacks a Messages*.php file.
 	 */
-	var $shallowFallbacks = array();
+	private $shallowFallbacks = array();
 
 	/**
 	 * An array where the keys are codes that have been recached by this instance.
 	 */
-	var $recachedLangs = array();
+	private $recachedLangs = array();
 
 	/**
 	 * All item keys
@@ -158,7 +158,7 @@ class LocalisationCache {
 	 * Associative array of cached plural rules. The key is the language code,
 	 * the value is an array of plural rules for that language.
 	 */
-	var $pluralRules = null;
+	private $pluralRules = null;
 
 	/**
 	 * Associative array of cached plural rule types. The key is the language
@@ -172,9 +172,9 @@ class LocalisationCache {
 	 * example, {{plural:count|wordform1|wordform2|wordform3}}, rather than
 	 * {{plural:count|one=wordform1|two=wordform2|many=wordform3}}.
 	 */
-	var $pluralRuleTypes = null;
+	private $pluralRuleTypes = null;
 
-	var $mergeableKeys = null;
+	private $mergeableKeys = null;
 
 	/**
 	 * Constructor.
-- 
2.20.1