From 19160cbca00a246d2eda50f55a8c8e561a14554b Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Sun, 4 Oct 2015 13:22:01 -0700 Subject: [PATCH] Remove return value from FormSpecialPage::checkExecutePermissions It is unused and few callers comply with it Change-Id: I3ac02ca996b57bf2222006712cc988a064dc38e5 --- includes/specialpage/FormSpecialPage.php | 3 --- includes/specials/SpecialPasswordReset.php | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/includes/specialpage/FormSpecialPage.php b/includes/specialpage/FormSpecialPage.php index 42c59806b4..d22875b9bd 100644 --- a/includes/specialpage/FormSpecialPage.php +++ b/includes/specialpage/FormSpecialPage.php @@ -169,7 +169,6 @@ abstract class FormSpecialPage extends SpecialPage { * Failures here must throw subclasses of ErrorPageError. * @param User $user * @throws UserBlockedError - * @return bool True */ protected function checkExecutePermissions( User $user ) { $this->checkPermissions(); @@ -182,8 +181,6 @@ abstract class FormSpecialPage extends SpecialPage { if ( $this->requiresWrite() ) { $this->checkReadOnly(); } - - return true; } /** diff --git a/includes/specials/SpecialPasswordReset.php b/includes/specials/SpecialPasswordReset.php index 9e72807f0b..f1eb8c2325 100644 --- a/includes/specials/SpecialPasswordReset.php +++ b/includes/specials/SpecialPasswordReset.php @@ -58,7 +58,7 @@ class SpecialPasswordReset extends FormSpecialPage { throw new ErrorPageError( 'internalerror', 'resetpass_forbidden' ); } - return parent::checkExecutePermissions( $user ); + parent::checkExecutePermissions( $user ); } protected function getFormFields() { -- 2.20.1