From 143333b172cd6c5465a92493a40ad423feb5f366 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Mon, 17 Jun 2019 00:20:55 +0100 Subject: [PATCH] rdbms: do not close the connection in LoadBalancerSingle::__destruct The connection instance is injected unlike with the parent class, meaning that it does not own the connection. No-op the method. Change-Id: I61914b986619f201ac9cc8c94d46873a3b9e8177 --- includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php b/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php index fcddfcf139..4c68833e7e 100644 --- a/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php +++ b/includes/libs/rdbms/loadbalancer/LoadBalancerSingle.php @@ -86,6 +86,10 @@ class LoadBalancerSingle extends LoadBalancer { protected function reallyOpenConnection( array $server, DatabaseDomain $domain ) { return $this->db; } + + public function __destruct() { + // do nothing since the connection was injected + } } /** -- 2.20.1