From 140a4f9788f40c755ca9319df50be81bfa155988 Mon Sep 17 00:00:00 2001
From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 20 Nov 2014 01:04:53 -0800
Subject: [PATCH] Fixed BloomCache handling of network partitions

* As documented, it should return true on error, so that DB is
  checked if the filter is down.

Change-Id: I883fafc9f5f3a84f85207de6e916f1630c78d1a4
---
 includes/cache/bloom/BloomCache.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/includes/cache/bloom/BloomCache.php b/includes/cache/bloom/BloomCache.php
index a15b4613ee..627f4f0db9 100644
--- a/includes/cache/bloom/BloomCache.php
+++ b/includes/cache/bloom/BloomCache.php
@@ -102,7 +102,7 @@ abstract class BloomCache {
 				$status = $this->getStatus( $virtualKey );
 				if ( $status == false ) {
 					wfDebug( "Could not query virtual bloom filter '$virtualKey'." );
-					return null;
+					return true;
 				}
 
 				$useFilter = call_user_func_array(
-- 
2.20.1