From 1214a7cae94f2190065e3fd53083f79bcb94957d Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jes=C3=BAs=20Mart=C3=ADnez=20Novo?= Date: Thu, 25 Aug 2016 16:07:57 +0200 Subject: [PATCH] Turn $wgRunJobsAsync off by default The current situation doesn't work in all installations and has being worse since MediaWiki 1.27. Default settings should be safe in all installations, and $wgRunJobsAsync wasn't one of them. Bug: T142751 Change-Id: I8daa38534a0e925a75ba2fb47e3e299f1baee4b1 --- RELEASE-NOTES-1.29 | 2 ++ includes/DefaultSettings.php | 5 +---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29 index ef9d734162..3af1654c3f 100644 --- a/RELEASE-NOTES-1.29 +++ b/RELEASE-NOTES-1.29 @@ -25,6 +25,8 @@ production. * $wgUserEmailUseReplyTo is now true by default to work around restrictive DMARC policies. * Subpages are now enabled by default in the Template namespace. Set $wgNamespacesWithSubpages[NS_TEMPLATE] to false to keep the old behavior. +* $wgRunJobsAsync is now false by default (T142751). This change only affects + wikis with $wgJobRunRate > 0. === New features in 1.29 === * (T5233) A cookie can now be set when a user is autoblocked, to track that user if diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index 09ea958318..f419b77425 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -8105,10 +8105,7 @@ $wgJobRunRate = 1; * * @since 1.23 */ -$wgRunJobsAsync = ( - !function_exists( 'register_postsend_function' ) && - !function_exists( 'fastcgi_finish_request' ) -); +$wgRunJobsAsync = false; /** * Number of rows to update per job -- 2.20.1