From 0f4fb8ecce329e3ec0a054666cf0f300687802b2 Mon Sep 17 00:00:00 2001 From: Raimond Spekking Date: Sat, 24 Apr 2010 20:07:13 +0000 Subject: [PATCH] * Add accesskey 's' and tooltip to 'Save' button at Special:Preferences --- RELEASE-NOTES | 1 + includes/Preferences.php | 2 ++ languages/messages/MessagesEn.php | 2 ++ maintenance/language/messageTypes.inc | 1 + maintenance/language/messages.inc | 2 ++ 5 files changed, 8 insertions(+) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 2bec9f1bbd..a772b25225 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -53,6 +53,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN is provided on the Upload form. * (bug 22647) Add category details in search results. * (bug 23276) Add hook to Special:NewPages to modify query +* Add accesskey 's' and tooltip to 'Save' button at Special:Preferences === Bug fixes in 1.17 === * (bug 17560) Half-broken deletion moved image files to deletion archive diff --git a/includes/Preferences.php b/includes/Preferences.php index d2ce5cef70..b9383d873a 100644 --- a/includes/Preferences.php +++ b/includes/Preferences.php @@ -1140,6 +1140,8 @@ class Preferences { $htmlForm = new PreferencesForm( $formDescriptor, 'prefs' ); $htmlForm->setSubmitText( wfMsg( 'saveprefs' ) ); + # Used message keys: 'accesskey-preferences-save', 'tooltip-preferences-save' + $htmlForm->setSubmitTooltip( 'preferences-save' ); $htmlForm->setTitle( SpecialPage::getTitleFor( 'Preferences' ) ); $htmlForm->setSubmitID( 'prefsubmit' ); $htmlForm->setSubmitCallback( array( 'Preferences', 'tryFormSubmit' ) ); diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php index 5c8b4853b7..43657f7ead 100644 --- a/languages/messages/MessagesEn.php +++ b/languages/messages/MessagesEn.php @@ -3294,6 +3294,7 @@ Please try again.', 'accesskey-compareselectedversions' => 'v', # do not translate or duplicate this message to other languages 'accesskey-watch' => 'w', # do not translate or duplicate this message to other languages 'accesskey-upload' => 's', # do not translate or duplicate this message to other languages +'accesskey-preferences-save' => 's', # do not translate or duplicate this message to other languages # Tooltip help for the actions 'tooltip-pt-userpage' => 'Your user page', @@ -3360,6 +3361,7 @@ You can view its source', 'tooltip-upload' => 'Start upload', 'tooltip-rollback' => '"Rollback" reverts edit(s) to this page of the last contributor in one click', 'tooltip-undo' => '"Undo" reverts this edit and opens the edit form in preview mode. It allows adding a reason in the summary.', +'tooltip-preferences-save' => 'Save preferences', # Stylesheets 'common.css' => '/* CSS placed here will be applied to all skins */', # only translate this message to other languages if you have to change it diff --git a/maintenance/language/messageTypes.inc b/maintenance/language/messageTypes.inc index 9b979b1912..7006fb76a4 100644 --- a/maintenance/language/messageTypes.inc +++ b/maintenance/language/messageTypes.inc @@ -69,6 +69,7 @@ $wgIgnoredMessages = array( 'accesskey-compareselectedversions', 'accesskey-watch', 'accesskey-upload', + 'accesskey-preferences-save', 'addsection', 'talkpageheader', 'anonnotice', diff --git a/maintenance/language/messages.inc b/maintenance/language/messages.inc index 33f54e52b6..c57abc5e26 100644 --- a/maintenance/language/messages.inc +++ b/maintenance/language/messages.inc @@ -2262,6 +2262,7 @@ $wgMessageStructure = array( 'accesskey-compareselectedversions', 'accesskey-watch', 'accesskey-upload', + 'accesskey-preferences-save', ), 'tooltips' => array( 'tooltip-pt-userpage', @@ -2328,6 +2329,7 @@ $wgMessageStructure = array( 'tooltip-upload', 'tooltip-rollback', 'tooltip-undo', + 'tooltip-preferences-save', ), 'stylesheets' => array( 'common.css', -- 2.20.1