From 0da3d2ff2b78ef0cf3385e6e9e626ce1a7f4d3d6 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Sat, 25 Feb 2017 22:38:46 +0100 Subject: [PATCH] Database: Remove weird commented-out block Commented out in 033b6b9646da6b71c5bb9dd6803a662bcf510a99 (r20329). After ten years, I think it's safe to bet this won't ever be getting un-commented. Change-Id: Ibb1f3e2969b2d81f6f2a17fff57e9b05cc17d58b --- includes/libs/rdbms/database/Database.php | 6 ------ includes/libs/rdbms/database/DatabasePostgres.php | 10 ++-------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/includes/libs/rdbms/database/Database.php b/includes/libs/rdbms/database/Database.php index 1c5c77e41c..a7952a6335 100644 --- a/includes/libs/rdbms/database/Database.php +++ b/includes/libs/rdbms/database/Database.php @@ -1141,12 +1141,6 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware $preLimitTail .= $this->makeOrderBy( $options ); - // if (isset($options['LIMIT'])) { - // $tailOpts .= $this->limitResult('', $options['LIMIT'], - // isset($options['OFFSET']) ? $options['OFFSET'] - // : false); - // } - if ( isset( $noKeyOptions['FOR UPDATE'] ) ) { $postLimitTail .= ' FOR UPDATE'; } diff --git a/includes/libs/rdbms/database/DatabasePostgres.php b/includes/libs/rdbms/database/DatabasePostgres.php index 109f8481d5..c62fec19db 100644 --- a/includes/libs/rdbms/database/DatabasePostgres.php +++ b/includes/libs/rdbms/database/DatabasePostgres.php @@ -1079,8 +1079,8 @@ __INDEXATTR__; $q = <<query( sprintf( @@ -1252,12 +1252,6 @@ SQL; $preLimitTail .= $this->makeOrderBy( $options ); - // if ( isset( $options['LIMIT'] ) ) { - // $tailOpts .= $this->limitResult( '', $options['LIMIT'], - // isset( $options['OFFSET'] ) ? $options['OFFSET'] - // : false ); - // } - if ( isset( $options['FOR UPDATE'] ) ) { $postLimitTail .= ' FOR UPDATE OF ' . implode( ', ', array_map( [ $this, 'tableName' ], $options['FOR UPDATE'] ) ); -- 2.20.1