From 0be51f9237f9c17ba343381e5e886d6e11e82a85 Mon Sep 17 00:00:00 2001 From: Aryeh Gregor Date: Sun, 16 Dec 2007 19:57:40 +0000 Subject: [PATCH] Moving pages seems to have been completely broken for unprotected titles; fixed that. Note that it doesn't seem as though it necessarily works properly for protected titles either (cursory test prohibited me as a sysop from moving over sysop protection), but I haven't looked too closely at that, I'm doing something else now. --- includes/Title.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/includes/Title.php b/includes/Title.php index f632392814..e10fe13df9 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -1253,7 +1253,8 @@ class Title { /** * Is this title subject to title protection? - * @return array An associative array representing any existent title protection. + * @return mixed An associative array representing any existent title + * protection, or false if there's none. */ public function getTitleProtection() { $dbr = wfGetDB( DB_SLAVE ); @@ -2305,7 +2306,7 @@ class Title { } } else { $tp = $nt->getTitleProtection(); - if (!$wgUser->isAllowed($tp['pt_create_perm'])) { + if ( $tp and !$wgUser->isAllowed( $tp['pt_create_perm'] ) ) { return 'cantmove-titleprotected'; } } @@ -2906,4 +2907,4 @@ class Title { return Namespace::isContent( $this->getNamespace() ); } -} \ No newline at end of file +} -- 2.20.1