From 0848d0e607d03e988b3dad8465611c75875c003d Mon Sep 17 00:00:00 2001 From: Alangi Derick Date: Mon, 3 Dec 2018 12:25:33 +0100 Subject: [PATCH] export: Fix return value of write() function in DumpOutput.php Per http://php.net/manual/en/function.print.php, print always returns 1 (integer value of one) but write() doesn't actually return this value to it's caller. So "@return bool" in this case doesn't make sense as one will think it's returning a bool type. `write()` only takes a string and prints it, and if we really want to return it's value (in this case), it will be "@return int" not data of type bool. Change-Id: I45b4a157cde2f768d77dda76d6ae0caa47e28f20 --- includes/export/DumpOutput.php | 1 - 1 file changed, 1 deletion(-) diff --git a/includes/export/DumpOutput.php b/includes/export/DumpOutput.php index edd73fcfc3..ab925b75ff 100644 --- a/includes/export/DumpOutput.php +++ b/includes/export/DumpOutput.php @@ -76,7 +76,6 @@ class DumpOutput { /** * Override to write to a different stream type. * @param string $string - * @return bool */ function write( $string ) { print $string; -- 2.20.1