From 07a395bd9beae9e9e88d032f9a135a454eed4ca4 Mon Sep 17 00:00:00 2001 From: Trevor Parscal Date: Wed, 13 Oct 2010 21:58:04 +0000 Subject: [PATCH] Fixes bug in wikibits that causes addPortletLink to fail when adding tabs to the vector skin. --- skins/common/wikibits.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js index 3b582dd954..d9dcb802b9 100644 --- a/skins/common/wikibits.js +++ b/skins/common/wikibits.js @@ -352,15 +352,16 @@ window.addPortletLink = function( portlet, href, text, id, tooltip, accesskey, n // unhide portlet if it was hidden before root.className = root.className.replace( /(^| )emptyPortlet( |$)/, "$2" ); - var span = document.createElement( 'span' ); - span.appendChild( document.createTextNode( text ) ); - var link = document.createElement( 'a' ); - link.appendChild( span ); + link.appendChild( document.createTextNode( text ) ); link.href = href; + // Wrap in a span - make it work with vector tabs and has no effect on any other portlets + var span = document.createElement( 'span' ); + span.appendChild( link ); + var item = document.createElement( 'li' ); - item.appendChild( link ); + item.appendChild( span ); if ( id ) { item.id = id; } -- 2.20.1