Ilmari Karonen [Fri, 10 Dec 2010 22:42:46 +0000 (22:42 +0000)]
followup r78209: fix typo, better word choice
Ilmari Karonen [Fri, 10 Dec 2010 22:39:17 +0000 (22:39 +0000)]
(bug 16019) Make WebRequest::interpolateTitle() do nothing when run from api.php
Alexandre Emsenhuber [Fri, 10 Dec 2010 20:51:06 +0000 (20:51 +0000)]
* Converted Special:Search to subclass SpecialPage
* Removed useless calls to $wgOut->setArticleRelated() and $wgOut->setRobotPolicy(), they are already handled by SpecialPage::setHeaders()
Alexandre Emsenhuber [Fri, 10 Dec 2010 19:47:54 +0000 (19:47 +0000)]
Moved 1.17 RELEASE-NOTES entries to HISTORY
Alexandre Emsenhuber [Fri, 10 Dec 2010 19:40:19 +0000 (19:40 +0000)]
Whoops, forgot to commit this with r78201
Chad Horohoe [Fri, 10 Dec 2010 19:38:58 +0000 (19:38 +0000)]
Fix for r78192, forgot to revert a test
Alexandre Emsenhuber [Fri, 10 Dec 2010 18:48:11 +0000 (18:48 +0000)]
Moved constant values from constructor to class definition
Alexandre Emsenhuber [Fri, 10 Dec 2010 18:23:33 +0000 (18:23 +0000)]
Fixes for r78201:
* Per Reedy, add braces where needed
* Revert one change that should not have been there
Alexandre Emsenhuber [Fri, 10 Dec 2010 18:17:20 +0000 (18:17 +0000)]
* (bug 19006) {{REVISIONUSER}} no longer acts like {{CURRENTUSER}} in some cases
* Removed other usages of $wgUser in Parser stuff, as stated in doc
* Added mechanism to get an User object in Parser, based either on the object given in Paser::preSaveTransform() or the ParserOptions otherwise
Roan Kattouw [Fri, 10 Dec 2010 17:21:09 +0000 (17:21 +0000)]
Make load.php output a comment explaining what's going on when no modules were requested rather than outputting nothing. Max made me do this because he hates blank pages
Roan Kattouw [Fri, 10 Dec 2010 17:06:00 +0000 (17:06 +0000)]
(bug 26130) ob_start( 'ob_gzhandler' ) in LocalSettings.php broke gzip output from load.php . This is caused by bugs.php.net/bug.php?id=36514 (ob_clean() removes GZIP header). Also noticed that load.php is affected by http://bugs.php.net/bug.php?id=51579 (ob_gzhandler generates non-empty 304s, invalid HTTP, triggers a Firefox bug) as well and fixed that too while I was at it.
Chad Horohoe [Fri, 10 Dec 2010 16:03:57 +0000 (16:03 +0000)]
Revert r68230, r68231 (mode="grid" on tables) per CR. It's in the history if anyone wants to work on this again
Sam Reed [Fri, 10 Dec 2010 15:48:17 +0000 (15:48 +0000)]
Followup r78101 fixme, remove wfQuotedPrintable per Roans CR
Chad Horohoe [Fri, 10 Dec 2010 15:15:16 +0000 (15:15 +0000)]
Fix for r71961 (moved SpecialPage constructor from named to __construct()). Intercept calls to parent::SpecialPage() with __call() so we don't break people still using the old constructor.
Niklas Laxström [Fri, 10 Dec 2010 14:44:01 +0000 (14:44 +0000)]
Reduce debug log spamming, which I assume is related to this line:
1340: function isBlocked( $bFromSlave = true ) { // hacked from false due to horrible probs on site
Niklas Laxström [Fri, 10 Dec 2010 14:40:50 +0000 (14:40 +0000)]
Better debug logging which isn't misleading
Chad Horohoe [Fri, 10 Dec 2010 14:17:13 +0000 (14:17 +0000)]
Last $wgDBtype usages in core. Use a $db member variable so we can use it in other useful places too.
Chad Horohoe [Fri, 10 Dec 2010 14:04:00 +0000 (14:04 +0000)]
One more $wgDBtype. I think this is the last offender in core; all the remaining usages are justified
Chad Horohoe [Fri, 10 Dec 2010 13:56:17 +0000 (13:56 +0000)]
Get rid of a bunch of $wgDBtypes in maintenance/
Chad Horohoe [Fri, 10 Dec 2010 13:39:42 +0000 (13:39 +0000)]
Kill $wgDatabase in trunk (no need to backport this to REL1_17, it's harmless). Isn't used in extensions in 1.15 or above.
There is a $wgDatabase in Metavidwiki (and StarterWiki in 1.16), but it constructs it itself, so it's not the same as the global I'm killing
Chad Horohoe [Fri, 10 Dec 2010 13:30:26 +0000 (13:30 +0000)]
Old installer is dead. Any leftover DBMS-specific old installer code is in initial_setup() or setup_database()
Niklas Laxström [Fri, 10 Dec 2010 13:18:11 +0000 (13:18 +0000)]
Fix regression in r70657. Misplaced else condition was causing cache misses
to try to load the message text and cache the result individually. However
in the default configuration cache miss always means that the message doesn't
exists in the database.
Niklas Laxström [Fri, 10 Dec 2010 12:03:39 +0000 (12:03 +0000)]
Don't unstub $wgOut just for adding debug messages
Roan Kattouw [Fri, 10 Dec 2010 11:33:51 +0000 (11:33 +0000)]
Followup r78117: information was still leaked through the caption of the Edit tab (which is "Create" for nonexistent pages) for users who had edit but not read rights. This may seem like a ridiculous case, but since we automatically disallow edit if you can't read, it's easy to forget to disallow editing as well as reading. Fixed this by not showing the edit tab at all if the user can't read (which makes sense since it's also hidden if the user is explicitly forbidden from editing).
Roan Kattouw [Fri, 10 Dec 2010 10:55:41 +0000 (10:55 +0000)]
Fix regression in r78117 per CR, was causing read, edit and history tabs to disappear for users who couldn't edit due to $wgEmailConfirmToEdit or $wgNamespaceProtection
Tim Starling [Fri, 10 Dec 2010 03:02:03 +0000 (03:02 +0000)]
* Hide the "back" buttons on the completion pages, they are potentially confusing and almost useless.
* Made the links to the wiki on the completion pages open in the same window, not a popup.
* Do not allow the user to regenerate LocalSettings.php when $wgUpgradeKey was given and the DB settings were prefilled, since this allows a leak of $wgUpgradeKey to escalate to a leak of $wgDBpassword. It's not unreasonable to require that the user removes their old LocalSettings.php when they wish to generate a new one.
* Rewrote the doc comment on $wgUpgradeKey, to discourage users from setting it to an easily guessable string, per concerns on CR r78118.
Aaron Schulz [Fri, 10 Dec 2010 00:16:28 +0000 (00:16 +0000)]
*Follow-up r78099,r76275:
**Converted CheckUser to use RL
**Made checkuser.js borrow block.js IP functions to avoid ugly duplication (and fix the IP recognition)
**Added missing backslashes to block.js regex strings and avoided backreferences (which work the opposite of PCRE when referencing an unmatched group)
*Made CU not give a common prefix if both v6 and v4 addresses are on the list
Krinkle [Fri, 10 Dec 2010 00:13:34 +0000 (00:13 +0000)]
whitespace clean up mw.util
Roan Kattouw [Fri, 10 Dec 2010 00:06:50 +0000 (00:06 +0000)]
Revert r78158, Aryeh tells me it's a deliberate browser hack
Roan Kattouw [Thu, 9 Dec 2010 23:47:59 +0000 (23:47 +0000)]
Fix bad CSS syntax from r77411
Krinkle [Thu, 9 Dec 2010 23:42:29 +0000 (23:42 +0000)]
Added a way to hide the jsMessage by calling with empty string, null or no arguments
Krinkle [Thu, 9 Dec 2010 23:29:26 +0000 (23:29 +0000)]
Ported jsMsg to mw.util; Fixing bugs and modernising mediawiki.action.watch.ajax.js a little more
* Using the raw element instead of jQuery object to get href. This way it's the complete url instead of what could potentially be a relative path (window.location.href is best passed a complete url)
* Adding 'mediawiki.legacy.ajax' as dependency for mediawiki.action.watch.ajax as it is and has been for a while.
* Ported jsMsg (legacy.wikibits) to mw.util.jsMessage()
Krinkle [Thu, 9 Dec 2010 22:47:58 +0000 (22:47 +0000)]
Follow-up r78150, removed accidental left-over console.logs calls
Krinkle [Thu, 9 Dec 2010 22:45:49 +0000 (22:45 +0000)]
Fixing bugs and modernising mediawiki.action.watch.ajax.js a little bit
* add() takes the selector directly. Passing a jQuery object either doesn't work or is an undocumented feature.
* using the mw.util functions instead of a less than perfect regex.
* closest() instead of parents() is faster and should be used whenever possible
* The this in processResult() didn't refer to the jQuery object of the anchor tag. It was probably never noticed since it's only used in the else{}-fallback (hard to mis). Fixed now by passing the link in the function
* The this in .bind('mw-ajaxwatch') didn't refer to this either, fixed also by passing into the function
* Replace() function in .bind('mw-ajaxwatch') didn't work, the slashes causes nothing to be matched at all. Before this the href stayed the same and didn't change accordingly.
Krinkle [Thu, 9 Dec 2010 22:00:42 +0000 (22:00 +0000)]
more specific, like action.view.rightclickedit, also action.watch.ajax
Krinkle [Thu, 9 Dec 2010 21:59:02 +0000 (21:59 +0000)]
start resourceloadify mw.legacy.ajaxwatch
Bryan Tong Minh [Thu, 9 Dec 2010 21:42:01 +0000 (21:42 +0000)]
Revert the addition of the patrol token from ApiQueryInfo from r78141; does not belong there
Bryan Tong Minh [Thu, 9 Dec 2010 21:29:03 +0000 (21:29 +0000)]
BREAKING CHANGE: Require POST for patrolling revisions and salt the patrol token with 'patrol' instead of rc_id.
See my comments on r75274, for which this is a follow-up. Using a dedicated, but constant patrol token is in my opinion the optimal compromise between performance (only require fetching the token once) and security (leaking the token will only compromise the patrolling feature).
Raimond Spekking [Thu, 9 Dec 2010 20:48:08 +0000 (20:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-09 20:29:00 UTC)
Chad Horohoe [Thu, 9 Dec 2010 20:36:52 +0000 (20:36 +0000)]
Followup r78118: $wgUpgradeKey was already in DefaultSettings, use Tim's better comment
Alexandre Emsenhuber [Thu, 9 Dec 2010 17:09:50 +0000 (17:09 +0000)]
For consistency: call set both article and article related flags to false instead of only article flag
Alexandre Emsenhuber [Thu, 9 Dec 2010 15:59:44 +0000 (15:59 +0000)]
Call finalCleanup() after outputting a cached page to run the deferred update list since Article::viewUpdates() adds a SiteStatsUpdate object to that list
Siebrand Mazeland [Thu, 9 Dec 2010 11:31:09 +0000 (11:31 +0000)]
* remove wfSeedRandom() which was marked for removal in 1.18.
* mark wfGetMimeMagic() for removal in 1.19.
* have wfLoadExtensionMessages() whine deprecated per comments and mark for removal in 1.20.
Siebrand Mazeland [Thu, 9 Dec 2010 11:27:59 +0000 (11:27 +0000)]
Follow-up r78101:
* add @deprecated to each deprecated method.
* add @since to new method.
Jeroen De Dauw [Thu, 9 Dec 2010 09:31:59 +0000 (09:31 +0000)]
Follow up to r77883
Tim Starling [Thu, 9 Dec 2010 08:24:54 +0000 (08:24 +0000)]
* Made the web upgrade process more friendly. Instead of saying "access denied, go away" when the user has a normal LocalSettings.php file, generate a random $wgUpgradeKey and instruct the user to insert it into their LocalSettings.php. The subsequent file modification then authenticates the session and allows the upgrade.
* When an upgrade key is entered, or a supplied upgrade key is edited into LocalSettings.php by the upgrader, fetch database settings from LocalSettings.php and AdminSettings.php for use during the upgrade. This allows the DBConnect page to be skipped, making web upgrade almost as easy to use as CLI upgrade.
* Made LocalSettingsGenerator add $wgUpgradeKey in non-commented form, for easier subsequent upgrades.
* Converted the $wgUpgradeKey check to a normal in-sequence page, called ExistingWiki. This allows the removal of related special cases from WebInstaller. The code for WebInstaller_ExistingWiki is loosely based on WebInstaller_Locked.
* Added Status::replaceMessage(), to support informative DB connection error messages from the ExistingWiki page.
* In WebInstaller::getInfoBox(), call parse() with $lineStart=true, so that line-start syntax like bullet points can work.
* Reduced the length of the generated $wgUpgradeKey from 64 to 16. This is ample for what it does, and makes it fit on the screen and not overlap with the right sidebar when when displayed by WebInstaller_ExistingWiki.
* Added $wgUpgradeKey to DefaultSettings.php.
Andrew Garrett [Thu, 9 Dec 2010 04:54:00 +0000 (04:54 +0000)]
Do not reveal page existence in colour of links in tabs when a user cannot read the page. This prevents leaking the existence (or not) of pages on wikis that are not readable anonymously
Andrew Garrett [Thu, 9 Dec 2010 04:08:23 +0000 (04:08 +0000)]
RELEASE-NOTES for r77555
Andrew Garrett [Thu, 9 Dec 2010 03:12:28 +0000 (03:12 +0000)]
Follow-up to r64937: expand ternary to conditionals because I hate nested ternaries.
Sam Reed [Wed, 8 Dec 2010 23:33:33 +0000 (23:33 +0000)]
Remove unneeded semicolons
Remove unneeded return
Simplify some if's (invert to save negation)
Trevor Parscal [Wed, 8 Dec 2010 23:18:58 +0000 (23:18 +0000)]
Added name and sessionId methods to user object - now anonymous users have an automatically generated persistent (for 30 days at a time via a cookie) session identifier. Use mediaWiki.user.sessionId() to get it.
Trevor Parscal [Wed, 8 Dec 2010 23:14:21 +0000 (23:14 +0000)]
Updated cookie plugin
Platonides [Wed, 8 Dec 2010 23:10:46 +0000 (23:10 +0000)]
Follow up r78101.
Platonides [Wed, 8 Dec 2010 23:09:29 +0000 (23:09 +0000)]
Move wfQuotedPrintable() into UserMailer class
Raimond Spekking [Wed, 8 Dec 2010 22:35:58 +0000 (22:35 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-08 20:15:00 UTC)
Aaron Schulz [Wed, 8 Dec 2010 22:33:26 +0000 (22:33 +0000)]
*Follow-up r76275: regexp improvement akin to IP.php
*Fixed "Error: updateBlockOptions is not defined
Source File: http://localhost/wiki/Special:Block/Lightning_Angel
Line: 121"
*TODO: get these functions to a nice JS file and let checkuser.js use then via RL
Aaron Schulz [Wed, 8 Dec 2010 22:18:43 +0000 (22:18 +0000)]
Fixed r76560: one more caller of now-private toUnsigned6
Roan Kattouw [Wed, 8 Dec 2010 20:10:11 +0000 (20:10 +0000)]
Remove unnecessary check against $wgAllowUserCss in ResourceLoaderUserModule that was used to trigger JS as well as CSS, breaking installs where user JS is allowed but user CSS is not. Callers already check for the relevant $wgAllow* variables before including this module.
Trevor Parscal [Wed, 8 Dec 2010 19:33:12 +0000 (19:33 +0000)]
Moved button styles from dialog specific areas to button specific areas to make all buttons look similar.
Mark A. Hershberger [Wed, 8 Dec 2010 19:17:56 +0000 (19:17 +0000)]
Revert r78005, verified that r78009 seems to have fixed the problem.
Sam Reed [Wed, 8 Dec 2010 19:16:10 +0000 (19:16 +0000)]
Revert unintended whitespace changes from r77922
Trevor Parscal [Wed, 8 Dec 2010 19:14:21 +0000 (19:14 +0000)]
Removing unused plugin file
Trevor Parscal [Wed, 8 Dec 2010 19:13:32 +0000 (19:13 +0000)]
Converted tabs introduced in 77910 to spaces - not because I like them that way, but because it's an external library and we are keeping it consistent.
Mark A. Hershberger [Wed, 8 Dec 2010 18:59:43 +0000 (18:59 +0000)]
re r75906 — replace the removed getSessionKey() with stashSession()
Raimond Spekking [Wed, 8 Dec 2010 18:02:40 +0000 (18:02 +0000)]
Consistenz spelling per translatewiki.net/w/i.php?title=Thread:Support/myskin.js_%26_myskin.css_%28IMO_pretty_much_the_same%29
Alexandre Emsenhuber [Wed, 8 Dec 2010 17:53:57 +0000 (17:53 +0000)]
addInlineScript() won't work since the content of $mScripts is added to $scripts before that call
Chad Horohoe [Wed, 8 Dec 2010 17:22:49 +0000 (17:22 +0000)]
(bug 22753) update.php should make things it actually changed stand out better in its report. Fixed the last update.php entry that isn't clear on when it did something or skipped a step. Now all of the "nothing done" messages should be prefixed by "...". We should probably abstract this somehow.
Alexandre Emsenhuber [Wed, 8 Dec 2010 17:20:34 +0000 (17:20 +0000)]
* Use Article::doEdit() instead of old Article::insertNewArticle()
* No need for globals ($wgTitle and $wgArticle)
Brian Wolff [Wed, 8 Dec 2010 16:01:50 +0000 (16:01 +0000)]
(bug 25512) Make it so that categories listed in the subcategory section of a page aren't prefixed with category: namespace.
This was originally caused by r53780. I'm presuming that it was accidental since that revision was about changing how lang converter is called.
Presumably no one noticed this since the bug does not appear if categorytree is installed.
Alexandre Emsenhuber [Wed, 8 Dec 2010 10:00:25 +0000 (10:00 +0000)]
Use the AutoLoader to load the AjaxDispatcher class
Alexandre Emsenhuber [Wed, 8 Dec 2010 08:03:52 +0000 (08:03 +0000)]
Removed OutputPage::setEncodings(); its current implementation just converts $wgInputEncoding and $wgOutputEncoding to lowercase but the inclusion of Language.php will set them back to uppercase.
So instead of playing with these variables, let's just remove that function.
Aaron Schulz [Wed, 8 Dec 2010 07:10:43 +0000 (07:10 +0000)]
Assert that revision timestamp actually matches Article->mTimestamp
Tim Starling [Wed, 8 Dec 2010 05:57:57 +0000 (05:57 +0000)]
Fix for r69139: create_function() is not allowed.
Aaron Schulz [Wed, 8 Dec 2010 03:47:04 +0000 (03:47 +0000)]
Added array type hint to addExtensionUpdate and marked some functions "protected"
Jack Phoenix [Tue, 7 Dec 2010 23:09:28 +0000 (23:09 +0000)]
trim trailing whitespace
Jack Phoenix [Tue, 7 Dec 2010 23:08:41 +0000 (23:08 +0000)]
coding style tweaks
Mark A. Hershberger [Tue, 7 Dec 2010 22:58:29 +0000 (22:58 +0000)]
Found an error when $res = false while running tests
Mark A. Hershberger [Tue, 7 Dec 2010 22:33:37 +0000 (22:33 +0000)]
Don't use dirname when you already have a directory.
Trevor Parscal [Tue, 7 Dec 2010 22:27:00 +0000 (22:27 +0000)]
Improves on r77693 by placing ResourceLoader "only styles" CSS links together with the other CSS links in buildCssLink rather than getHeadItems which is used for meta information.
Mark A. Hershberger [Tue, 7 Dec 2010 21:53:50 +0000 (21:53 +0000)]
Filenames with quotes fail here.
Trevor Parscal [Tue, 7 Dec 2010 21:45:06 +0000 (21:45 +0000)]
Improves on r77693 by ensuring site styles are loaded just before user styles.
Ilmari Karonen [Tue, 7 Dec 2010 21:18:42 +0000 (21:18 +0000)]
compress images with pngout for a couple more skins
Ilmari Karonen [Tue, 7 Dec 2010 21:15:12 +0000 (21:15 +0000)]
a few more images compressed with pngout
Ilmari Karonen [Tue, 7 Dec 2010 21:11:53 +0000 (21:11 +0000)]
more lossless PNG compression with pngout
Raimond Spekking [Tue, 7 Dec 2010 21:11:28 +0000 (21:11 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-07 20:38:00 UTC)
Chad Horohoe [Tue, 7 Dec 2010 21:08:24 +0000 (21:08 +0000)]
Typofix r77999
Ilmari Karonen [Tue, 7 Dec 2010 21:04:06 +0000 (21:04 +0000)]
losslessly compress images with pngout
Chad Horohoe [Tue, 7 Dec 2010 20:49:10 +0000 (20:49 +0000)]
Per CR, no need for an empty constructor
Platonides [Tue, 7 Dec 2010 20:40:15 +0000 (20:40 +0000)]
Remove the $wgCaches[CACHE_DB] = false; line added in r74552.
It produces an strange failure when going out of ParserTest::setUp() scope.
(eg. $parserMemc becoming back false instead of a FakeMemcached, related to
using a reference in $wgMemc = &wfGetMainCache() )
Can be checked when running phpunit.php includes/ParserOptionsTest.php
See https://bugzilla.wikimedia.org/show_bug.cgi?id=26244#c4
No errors found in sqlite without it.
Chad Horohoe [Tue, 7 Dec 2010 20:13:47 +0000 (20:13 +0000)]
Per CR, fix debugging code from r70835
Chad Horohoe [Tue, 7 Dec 2010 20:03:54 +0000 (20:03 +0000)]
Logic error from r77999
Mark A. Hershberger [Tue, 7 Dec 2010 20:00:57 +0000 (20:00 +0000)]
References causing Bug #26244? This should find a way to just use
what Setup.inc already does.
Daniel Friesen [Tue, 7 Dec 2010 19:58:04 +0000 (19:58 +0000)]
Follow up r78003, forgot to make MonoBook use the footericons code.
Daniel Friesen [Tue, 7 Dec 2010 19:45:09 +0000 (19:45 +0000)]
Commit getFooterLinks and getFooterIcons helpers to abstract the common code used to trim footerlinks down to only valid items, flatten it if needed, trim non-image icons out of footericons, and remove the copyright icon if needed.
Chad Horohoe [Tue, 7 Dec 2010 18:32:09 +0000 (18:32 +0000)]
Also ditch PHP thing. We would've bailed for a bad version already
Chad Horohoe [Tue, 7 Dec 2010 18:29:04 +0000 (18:29 +0000)]
Remove various "success" messages from Welcome screen on installer, no need to confuse the user with extra info :) Now we only show warnings and failures
Daniel Friesen [Tue, 7 Dec 2010 18:18:09 +0000 (18:18 +0000)]
Followup r77980, for simplesearch I guess we'll have to stick with type=text instead of type=search.
Raimond Spekking [Tue, 7 Dec 2010 17:25:49 +0000 (17:25 +0000)]
follow-up r77981: Fix class: mw-js -> mw-css for the CSS section
Add comments with the full message keys to make sure grep will find them
Daniel Friesen [Tue, 7 Dec 2010 16:29:49 +0000 (16:29 +0000)]
Follow up r77893, add BaseTemplate to autoloader.
Platonides [Tue, 7 Dec 2010 16:26:10 +0000 (16:26 +0000)]
Follow up r77884.