Tim Starling [Tue, 8 Feb 2011 05:33:17 +0000 (05:33 +0000)]
Fix bug from r73645: setMsgBlobMtime() requires its timestamp parameter to be a UNIX timestamp, which $row->mr_timestamp isn't. This was causing incorrect versions in the client-side module list, resulting in requests for URLs with "version=NaNNaNNaNTNaNNaNNaNZ", which Michael has been occasionally complaining about.
Brion Vibber [Tue, 8 Feb 2011 02:02:16 +0000 (02:02 +0000)]
* (bug 27230) Alignment fix for Vector watch tab icon spinner in IE 7
The CSS for the loading tab had:
background-position: center 60%;
The 'center' apparently worked for other browsers, but in IE7 it was getting a bit off, and threw the image over a few pixels.
'center' keyword here is allegedly equivalent to 50% which I also tried, but with the same results.
Instead, using the same fixed position that we specify for the regular rest-state icon works:
background-position: 5px 60%;
Resulting looks ok for me in:
* IE 6 / XP
* IE 7 / XP (fixes regression)
* IE 8 / XP
* Firefox 4b10 / Linux
Shouldn't hurt anything else.
Daniel Friesen [Tue, 8 Feb 2011 01:31:21 +0000 (01:31 +0000)]
Followup r81583, break some of the long lines and centralize the regex.
Daniel Friesen [Tue, 8 Feb 2011 01:15:50 +0000 (01:15 +0000)]
Fix bug slightly caused by moving legacy code out of the Skin class. The Article class was calling the legacy Skin::historyLink in a very ugly way (ie: having it's own mTitle, but relying on whatever title just happened to be set on the skin that it grabbed).
Chad Horohoe [Tue, 8 Feb 2011 01:08:06 +0000 (01:08 +0000)]
Cleanup to r70900, r72481: don't construct new skin objects just because the Title is passed. Use the skin object we already have if the titles are the same
Krinkle [Tue, 8 Feb 2011 00:22:03 +0000 (00:22 +0000)]
Follow-up r81660.
(Renaming new jQuery.jsMessage plugin to jQuery.mesageBox() )
Krinkle [Tue, 8 Feb 2011 00:20:41 +0000 (00:20 +0000)]
Renaming new jQuery.jsMessage plugin to jQuery.mesageBox(). Name was too generic and could be confusing with localization messages.
. Next commit will deal with the contents of the messageBox .js/css files
Sam Reed [Mon, 7 Feb 2011 23:21:53 +0000 (23:21 +0000)]
Per fixme on r77597, change to $this->addQuotes() instead of hardcoded quote type
Tim Starling [Mon, 7 Feb 2011 22:11:27 +0000 (22:11 +0000)]
Fix whitespace from r80978
Roan Kattouw [Mon, 7 Feb 2011 21:55:11 +0000 (21:55 +0000)]
Followup r81491: use $.client correctly
Brion Vibber [Mon, 7 Feb 2011 21:45:19 +0000 (21:45 +0000)]
Fix for renamed stuff that broke jquery.textSelection.js: $.os.name -> $.client.platform
Raimond Spekking [Mon, 7 Feb 2011 21:06:29 +0000 (21:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-07 20:45:00 UTC)
Bryan Tong Minh [Mon, 7 Feb 2011 18:13:19 +0000 (18:13 +0000)]
Follow-up r81401: fix callback, apparently it was the other way around than I thought.
Alexandre Emsenhuber [Mon, 7 Feb 2011 16:42:41 +0000 (16:42 +0000)]
We have OutputPage::wrapWikiMsg() and OutputPage::addWikiMsg(), so use them
Alexandre Emsenhuber [Mon, 7 Feb 2011 16:17:50 +0000 (16:17 +0000)]
Simplify a bit by passing directly the value returned by doUnblock() to showForm() in case of error
Alexandre Emsenhuber [Mon, 7 Feb 2011 15:59:58 +0000 (15:59 +0000)]
Break lines at 80 chars
Tim Starling [Mon, 7 Feb 2011 12:39:10 +0000 (12:39 +0000)]
Use the content language to set the skin direction, instead of the user language. This makes the content readable and the UI messed up, instead of vice versa.
It's not ideal, but at least it's no worse than it was in 1.16. It's preferable because the content area is more likely to have bidirectional text than the UI area. The UI is split up into short strings, generally in a consistent language, so there is less chance of the UBA moving fragments of text around.
Ideally, the direction of each div would be set according to the language of the text it contains.
Raimond Spekking [Mon, 7 Feb 2011 07:32:06 +0000 (07:32 +0000)]
Follow-up r81619: Add new message key to maintenance file
Rob Lanphier [Mon, 7 Feb 2011 03:18:12 +0000 (03:18 +0000)]
Followup to r69185, putting the "dir" attribute back on the HTML root element
Brion Vibber [Mon, 7 Feb 2011 02:35:35 +0000 (02:35 +0000)]
* (bug 18011) Special:FileDuplicateSearch UI fixes and remote file repo support
Fixes:
- now accepts file titles with or without File: prefix instead of demanding you must remove it
- moved result summary line from bottom to top
- added a line telling you no file was found if it wasn't found
- now pulls the reference file's SHA-1 via FileRepo, so can give it a remote file (eg from Commons)
- now pulls duplicate files via the main RepoGroup instead of querying image table manually, so turns up remote duplicates
- dropped the QueryPage standard paging header/footer; file dupe lists are usually very short and it's not worth copying the infrastructure
To make this work, I switched the special page class from using the standard QueryPage paths to doing the query and list itself; QueryPage is currently very tightly tied in to database queries, and doesn't provide a very clean way to drop in an alternative way of looking stuff up (say an API query or just getting a big array you've gotten from somewhere). If that gets improved, this page should be cleaned up to use more of the QueryPage infrastructure again so it's pretty and doesn't scare people coming in to maintain it.
Localization changes:
- added fileduplicatesearch-noresults message
- changed fileduplicatesearch-summary in English master to remove the supplementary line about taking out the 'File:' prefix
Sam Reed [Mon, 7 Feb 2011 00:00:44 +0000 (00:00 +0000)]
Followup r81600, put bug fix incorrect BUG FIX section, rather than the API section, which is wrong
Sam Reed [Sun, 6 Feb 2011 23:59:03 +0000 (23:59 +0000)]
* (bug 27205) aiprop=metadata and aiprop=parsedcomment need help text
Refactored code out to reduce duplication (and hence, mismatches like this)
Bryan Tong Minh [Sun, 6 Feb 2011 22:53:07 +0000 (22:53 +0000)]
Follow-up r81612, disable $wgAllowAsyncCopyUploads
Bryan Tong Minh [Sun, 6 Feb 2011 22:47:10 +0000 (22:47 +0000)]
Cleanup MimeMagic: Add public identifier to functions; kill error operator; Cleanup function documentation; Manual stylize
Bryan Tong Minh [Sun, 6 Feb 2011 22:44:01 +0000 (22:44 +0000)]
Per CR r66438 and IRC, revert User::leaveNewMessage for now. Copied the function and stripped it down for use in NewUserMessage. Could probably need some cleanup.
Chad Horohoe [Sun, 6 Feb 2011 22:36:33 +0000 (22:36 +0000)]
Revert r66977 (removing $wgTitle from edit.php). This doesn't break core, but could quite possibly break extensions that expect $wgTitle to be set during editing. I hate $wgTitle :(
Antoine Musso [Sun, 6 Feb 2011 22:14:32 +0000 (22:14 +0000)]
Ignore code coverage for compatibility and shell functions
The compatibility functions in GlobalFunctions are just wrapper for
their equivalent in the Fallback class. We should test the implementation
and we can safely ignore those wrappers.
Shell functions ignored make use of sleep() which is evil. They also
do some outputs to the console which is probably hard to test properly.
Given they are not critical, I just ignore their code coverage, we can
still test them though :)
Antoine Musso [Sun, 6 Feb 2011 22:10:48 +0000 (22:10 +0000)]
Complete coverage of Xml::DateMenu()
r81605 was not hitting all possible conditional tests. Verified with:
php phpunit.php --configuration suite.xml \
--coverage-html /tmp/datecover \
--filter DateMenu
Tests:
PHPUnit 3.5.10 by Sebastian Bergmann.
.
Time: 3 seconds, Memory: 27.50Mb
OK (1 test, 5 assertions)
Brion Vibber [Sun, 6 Feb 2011 21:47:58 +0000 (21:47 +0000)]
Fixed an incorrect doc comment bit on Database::sourceStream, then added some more doc comments around the file just cause
Antoine Musso [Sun, 6 Feb 2011 21:28:57 +0000 (21:28 +0000)]
Move some providers in new MediaWikiProvide class
The MediaWikiProvide class would host providing methods reused in different
tests classes. To use it, just use the Class::function syntax.
Example:
/** @dataProvider MediaWikiProvide::Months */
Made a svn copy of phpunit/includes/parser/MagicVariableTest.php
to save the history.
Raimond Spekking [Sun, 6 Feb 2011 21:25:59 +0000 (21:25 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-06 21:10:00 UTC)
Antoine Musso [Sun, 6 Feb 2011 21:23:12 +0000 (21:23 +0000)]
Tests for Xml::DateMenu()
Ilmari Karonen [Sun, 6 Feb 2011 21:08:48 +0000 (21:08 +0000)]
(bug 23315) Add new body classes to allow easier styling of special pages.
Also eliminate some duplicate code introduced into SpecialPage::headElement() in r61071 by calling Skin::getPageClasses() instead, and use $sk parameter instead of $wgUser->getSkin() to get skin name.
Antoine Musso [Sun, 6 Feb 2011 20:24:53 +0000 (20:24 +0000)]
Reduce range of IPv6 tested by testValidIPs
By using steps of 0xF, the number of assertions is reduced from 70k
to 5k revisions. It is not that useful to test all of them.
Follow up r76569
Bryan Tong Minh [Sun, 6 Feb 2011 19:20:57 +0000 (19:20 +0000)]
Files with a mime type that does not match the extension are now properly thumbnailed. Partial bug fix to bug 26661.
MediaHandler::getThumbType now checks if the extension and the mime type match. If they do not, a new extension is generated for the mime type. The rest of the thumbnailing code should then magically work.
Bonus: this also works with file names without extension, so might be a step closer to extension-less files.
Ilmari Karonen [Sun, 6 Feb 2011 18:25:08 +0000 (18:25 +0000)]
(bug 27201) fix duplicate IDs in recursive whatlinkshere output
Antoine Musso [Sun, 6 Feb 2011 18:02:47 +0000 (18:02 +0000)]
wfShorthandToInteger() PHPUnit code coverage
Some easy assertions.
$ php phpunit.php --configuration suite.xml --filter Shorthand
PHPUnit 3.5.10 by Sebastian Bergmann.
...........................
Time: 2 seconds, Memory: 22.00Mb
OK (27 tests, 27 assertions)
Antoine Musso [Sun, 6 Feb 2011 14:47:35 +0000 (14:47 +0000)]
bugfix for wfBCP47 and code coverage
Language code are case insensitive. The BCP 47 recommands nice
formatting nonetheless. This patch enhance our formatting:
- tags preceded by the private tag 'x' are now lower case
- 4 letters tags are now lower case with first letter uper cased
Please note the RFC seems to have a bug for az-Arab-x-AZE-derbend
which should be az-Arab-x-aze-derbend . I have changed our test
to reflect this and added a comment for later reference.
Antoine Musso [Sun, 6 Feb 2011 13:59:06 +0000 (13:59 +0000)]
Improve PHPUnit code coverage
XmlJs:
- simple class == simple test
GlobalFunctions:
- wfArrayDiff2: simple test, please add more
XmlSelectTest:
- test for constructor
- tests for setDefault. Found a potential bug when setting a default after
options have been added. The default option will not get marked as selected!
We should change our code to generates HTML for options at rendering time
or throw an exception that default can not be used if an option is present.
MediaWiki:
- basic placeholder generated by PHPUnit
- tests for setVal() / getVal()
Alexandre Emsenhuber [Sun, 6 Feb 2011 13:41:32 +0000 (13:41 +0000)]
I don't think we need a complete parse operation to just add "<hr />"
Alexandre Emsenhuber [Sun, 6 Feb 2011 13:38:29 +0000 (13:38 +0000)]
Easier to just use addWikiMsg()
Alexandre Emsenhuber [Sun, 6 Feb 2011 12:38:33 +0000 (12:38 +0000)]
* Changed all calls to wfMsgWikiHtml() in core
* Now replacing parameter before parsing where possible
* Used 'parseinline' for 'nosuchuser' message in Special:Userlogin for consistency with other error messages
Rotem Liss [Sun, 6 Feb 2011 11:54:30 +0000 (11:54 +0000)]
Localization update for he.
Raimond Spekking [Sun, 6 Feb 2011 11:19:04 +0000 (11:19 +0000)]
Change $separatorTransformTable per discussion on translatewiki.net/wiki/Thread:Support/Customization_of_number_format
Krinkle [Sun, 6 Feb 2011 03:31:32 +0000 (03:31 +0000)]
Three small fixes to mediawiki.specials.preferences.js
* Moving class-adder from mousedown() to click().
Mousedown also fires when opening the contextmenu (right-click). If I right-clicked, say, preftab-4 to open in a new tab, it would work (thanks to r81573), but it would also trigger the 'selected'-class on that tab (which is wrong and out-of-sync since click() did not and should not fire). This behaviour was the case in Safari 5/Firefox 3 (Mac) and Chrome (Windows). Moving it to click() should not have any affect on the behaviour in other browsers.
Test it at: http://api.jquery.com/mousedown/
* Wrapping the hash-jump in a document.ready function.
This module is enclosed in a self-executing anonymous function to enforce private scope passing mediaWiki and jQuery. Although that, (<code>(function($,mw){ /* ... */ })(jQuery,mediaWiki);</code>) may look like a shortcut for jQuery(document).ready(), it is not. (Because both <code>;</code> and <code>jQuery(function{ /* ... */ });</code> look alike and are shortcuts). Anyway, wrapping it now to avoid it jumping too early.
* Using second argument of .each(), which is a reference to 'this'
By using that (named) variable instead there's no confusion with the other 'this' inside the click event binder – which refers to the then-clicked element (the anchor tag) rather than the legend-element.
Mark A. Hershberger [Sun, 6 Feb 2011 03:06:45 +0000 (03:06 +0000)]
Make schema selection really work for PostgreSQL installation
Daniel Friesen [Sun, 6 Feb 2011 01:38:33 +0000 (01:38 +0000)]
Switch <editsection> to <mw:editsection> and start hiding these editsection tags from Tidy so it doesn't break them.
Daniel Friesen [Sun, 6 Feb 2011 00:20:54 +0000 (00:20 +0000)]
Add releasenotes for r81507.
Antoine Musso [Sat, 5 Feb 2011 23:41:29 +0000 (23:41 +0000)]
Tests for XmlSelect::addOption()
PHPUnit seems to only accept one class per test file. This patch move the
XmlSelect class to a new file.
It also add some assertions for XmlSelect::addOption(). Please review them
carefully! Although the assertions are fine:
OK (5 tests, 5 assertions)
I am not sure they are the expected behaviour.
Daniel Friesen [Sat, 5 Feb 2011 23:06:36 +0000 (23:06 +0000)]
Kill off Linker::getExternalLinkAttributes.
Antoine Musso [Sat, 5 Feb 2011 22:55:09 +0000 (22:55 +0000)]
Avoid code duplication for Language::isValidCode
r81335 changed the way we validate language code by introducing:
strcspn( $code, "/\\\000" ) !== strlen( $code )
That code was later made a function in r81340 but some conditional tests were
not updated to reflect this change.
Purodha B Blissenbach [Sat, 5 Feb 2011 22:27:34 +0000 (22:27 +0000)]
Typo in a comment.
Mark A. Hershberger [Sat, 5 Feb 2011 22:20:09 +0000 (22:20 +0000)]
followup r13884 add CASCADE so that if the tables are created a second
time, errors aren't given.
Brion Vibber [Sat, 5 Feb 2011 21:54:56 +0000 (21:54 +0000)]
Preserve Special:Preferences tab state across reload, open in new tab/window.
* removed the preventDefault()s from handlers on the tab links, so the document hash gets updated (and thus preserved on reload)
* switched from #prefsection-N to #preftab-N on the generated links, so they don't cause the doc to jump down to the top of the tab sections on click now that the preventDefault is gone
* added a check for the hash after tab setup; if we have a #preftab-N then we invoke the tab-switch straight off.
This should keep devs from going insane when doing work on any preferences panel other than the first one
Brion Vibber [Sat, 5 Feb 2011 21:06:44 +0000 (21:06 +0000)]
Add a @fixme comment on FormatJson::encode(); the '$isHtml' parameter's purpose and function is not documented, but it seems to map to a pretty-printing parameter on Services_JSON(). If that's its purpose, it should be renamed and documented. Since it's a bare boolean parameter with no clear purpose in calls when "true" or "false" is passed bare, it probably also wants a nice legible constant value or two.
Daniel Friesen [Sat, 5 Feb 2011 20:28:04 +0000 (20:28 +0000)]
Html::expandAttributes( array( 'foo' => null ) ); ' foo=""' -> ''
Outputting ' foo="" on `foo = null` promotes the writing of overly verbose code to avoid it, and ugly methods like our old Linker::getLinkAttributesInternal, both of which are completely counter to the purpose of Html::.
Daniel Friesen [Sat, 5 Feb 2011 20:25:17 +0000 (20:25 +0000)]
Followup r81569, kill the wfDeprecated for now till we can actually get rid of the use of languagesHtml.
Daniel Friesen [Sat, 5 Feb 2011 20:16:42 +0000 (20:16 +0000)]
Followup comment to r81507. The api is using a legacy langlinks method no modern skin uses. Deprecating this and giving it it's own langlinks generation so that the api will be unaffected by anything we do to legacy skins.
Alexandre Emsenhuber [Sat, 5 Feb 2011 20:15:49 +0000 (20:15 +0000)]
Easier to use addWikiText() in wrapWikiMsg()
Raimond Spekking [Sat, 5 Feb 2011 20:11:54 +0000 (20:11 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-05 19:57:00 UTC)
Platonides [Sat, 5 Feb 2011 20:05:00 +0000 (20:05 +0000)]
Fix problem when running a fakePipeFound, which could lead to literals being incorrectly added to the part node instead of the value node.
Antoine Musso [Sat, 5 Feb 2011 16:25:18 +0000 (16:25 +0000)]
Fix @dataProvider with PHPUnit 3.5.8+
MediaWikiTestCase duplicates code from PHPUnit constructor. It worked
fine until PHPUnit 3.5.8 made FrameWork_TestCase attributes private,
thus the children class is no more able to update them ($data for example)
The change break any tests making use of the @dataProvider helper.
PHPUnit commit:
https://github.com/sebastianbergmann/phpunit/commit/
0b85d08c39ce689bc7320ebc03e7e5a4bfdbcbac
TESTS:
3.5.7 : OK -> OK
3.5.8 : KO -> OK
3.5.10 : KO -> OK
make databaseless
Tests: 486, Assertions: 73986, Incomplete: 1, Skipped: 3.
(skipped tests are SQLite related)
Alexandre Emsenhuber [Sat, 5 Feb 2011 15:11:52 +0000 (15:11 +0000)]
Deprecated wfMsgWeirdKey(), use wfMessage() instead. Moved getDefaultMessageText() from Article to Title so that it can be used there instead of duplicating code. No usage in extensions.
Antoine Musso [Sat, 5 Feb 2011 13:54:26 +0000 (13:54 +0000)]
doxygen: add support for EXCLUDE keyword
Antoine Musso [Sat, 5 Feb 2011 12:48:26 +0000 (12:48 +0000)]
minor typo in comment
Thanks to Solitarius for the report (by email)
Brian Wolff [Sat, 5 Feb 2011 08:49:48 +0000 (08:49 +0000)]
(bug 26548) Make multi-paged documents (PDFs) work with ForeignAPIRepo (aka InstantCommons).
This adds a new parameter to the query=imageinfo (and query=stashimageinfo) that takes rendering
parameters other than width and height. This could be page for pdf's and DjVu, or thumbtime for ogg's, etc.
Syntax is &iiurlparam=param1=value1|param2=value2|... I'm not sure if that really fits with the normal way
of doing things in the api, but couldn't think of anything better since the parameters are arbitrary.
I also noticed that some of the pre-existing error codes in query=imageinfo seem to duplicate the module prefix. I'm
not sure what the deal with that is, but i did not follow that example in the new error codes i introduced.
Note: In order for this to work, both the foreign repo and the local wiki have to be running this code.
Brian Wolff [Sat, 5 Feb 2011 02:16:13 +0000 (02:16 +0000)]
(follow up r79706 to address CR comments) Simplify some of the logic in LinksUpdate.php
Make it so that by default, the parser consdiers categories to have a sortkey of "" unless
specified otherwise. Before, the parser said the sortkey was the page name, and then in LinksUpdate
we reset the sortkey (prefix) to "" if it was the same as the page name.
This way, the parser uniformly outputs the sortkey prefix, instead of a mix between prefix or pagename.
It should be noted, this changes the output of api.php?action=parse for categories that do not have
a sortkey.
Brion Vibber [Sat, 5 Feb 2011 00:58:07 +0000 (00:58 +0000)]
* (bug 27083) Extension info for Special:Version can include '...' as a special value which is turned into the localized 'others' used for Special:Version author lists.
Mark A. Hershberger [Fri, 4 Feb 2011 21:44:24 +0000 (21:44 +0000)]
These table renames aren't needed for an upgrade since Pg has these as reserved names anyway.
Brian Wolff [Fri, 4 Feb 2011 21:38:54 +0000 (21:38 +0000)]
Currently, we do not send last-modified headers for the RC if patrolling is in use, since that messes with the way we determine if the RC has changed. Change it to not send those headers only if using RC patrol, and the current user can
see patrol marks.
As an aside, Special:Recentchanges does not show new page patrol marks
if $wgUseNPPatrol = true, but $wgUseRCPatrol=false (it only shows them if
both are true), where Special:newpages shows patrol stuff whenever $wgUseNPPatrol
is true, regardless of $wgUseRCPatrol. Which is a tad weird, but whatever.
Chad Horohoe [Fri, 4 Feb 2011 21:12:02 +0000 (21:12 +0000)]
Remove unused interwiki.sql like I said I would in r66013
Chad Horohoe [Fri, 4 Feb 2011 21:10:02 +0000 (21:10 +0000)]
Suppress warnings on reading interwiki.list in case permissions or something else makes it not work.
Tweak message since we no longer read the .sql file.
Raimond Spekking [Fri, 4 Feb 2011 21:04:49 +0000 (21:04 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-04 20:33:00 UTC)
Chad Horohoe [Fri, 4 Feb 2011 21:00:17 +0000 (21:00 +0000)]
More uppercase trues
Chad Horohoe [Fri, 4 Feb 2011 20:54:43 +0000 (20:54 +0000)]
lowercase a few more t/f
Bryan Tong Minh [Fri, 4 Feb 2011 20:54:11 +0000 (20:54 +0000)]
(bug 19751) Filesystem is now checked during image undeletion
* FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set
* Introduced Status::$success in addition to Status::$successcount
** FSRepo::storeBatch() now logs success/failure in this variable
* LocalFileRestoreBatch now aborts on failure in FSRepo::storeBatch() and cleans up the already copied files
** Introduced FSRepo::cleanupBatch() for this purpose
* SpecialUndelete now aborts if LocalFile::restore() gives a fatal
Chad Horohoe [Fri, 4 Feb 2011 20:52:55 +0000 (20:52 +0000)]
Rm selectDB from Postgres, doesn't do anything
Mark A. Hershberger [Fri, 4 Feb 2011 20:05:05 +0000 (20:05 +0000)]
change from double quote to single quote to avoid double-encoding by htmlspecialchars()
Alexandre Emsenhuber [Fri, 4 Feb 2011 16:52:26 +0000 (16:52 +0000)]
Use wfMessage() instead of wfMsgGetKey()
Alexandre Emsenhuber [Fri, 4 Feb 2011 16:47:24 +0000 (16:47 +0000)]
Allow parameter to be passed with an array in the first parameter (as other wfMsg*() functions)
Krinkle [Fri, 4 Feb 2011 16:44:07 +0000 (16:44 +0000)]
user scripts & styles are lowercase skin; + using 'vector' as example instead.
Happy-melon [Fri, 4 Feb 2011 16:41:31 +0000 (16:41 +0000)]
Release notes for r81524
Happy-melon [Fri, 4 Feb 2011 16:39:17 +0000 (16:39 +0000)]
Follow-up r64670 (bug22929): cleaner implementation of security for script (and potentially CSS) files. ResourceLoader *already* knows where each module has come from, so all we need to do is filter them in OutputPage according to the desired level of 'trustworthiness'.
TODO:
* Are there instances where we might want to restrict CSS as well as JS?
* Would a $wg config option and/or user preference and/or index.php GET parameter to limit inclusion be useful?
* Can we deprecate any of the existing $wg config options?
* What's going on with the duplicated code between OutputPage and SkinTemplate?
Chad Horohoe [Fri, 4 Feb 2011 15:03:59 +0000 (15:03 +0000)]
Revert r73198 (adding exclusing option to runJobs.php). Per CR, this should use a real pool counter.
Daniel Friesen [Fri, 4 Feb 2011 04:18:05 +0000 (04:18 +0000)]
Completely remove support for legacy style skins. All legacy skinning options are now part of a SkinLegacy/LegacySkinTemplate pair that inherits from the normal SkinTemplate setup. Also ported our three built in skins to use the new legacy classes. ( ;) if you want to kill legacy skins now, you only have to svn rm 4 files)
Krinkle [Fri, 4 Feb 2011 03:30:50 +0000 (03:30 +0000)]
more clear
Krinkle [Fri, 4 Feb 2011 03:30:14 +0000 (03:30 +0000)]
adding that Vector shipped with 1.16 in 2010
Krinkle [Fri, 4 Feb 2011 02:17:14 +0000 (02:17 +0000)]
Making a start with $.jsMessage. A more flexible way for messages. Supports grouping them and making the replacing of previous messages into option (the current jsMsg() function always replaces older messages. Time has shown that there is need for the ability to show older messages as well and grouping to avoid different scripts from erasing or clearing eachother's output (current Commons and a few other wikis have created similar functions to enable keeping previous messages)
* See also bug 26888. Not resolving the bug yet, this plugins needs a little more testing and should then be called from within mw.util.jsMessage with some wiki specific things.
Examples:
// Show a simple message in the default group
$.jsMessage( {
message: 'Hello',
target: 'mw-js-message'
} );
// Add a new message this time stating the defaults
$.jsMessage( {
message: 'World',
group: 'default',
replace: false,
target: 'mw-js-message'
} );
// Post a new message, replacing the previous ones
$.jsMessage( {
message: 'New',
group: 'default',
replace: true,
target: 'mw-js-message'
} );
// Add a messages in a new group (groups separated by a line)
$.jsMessage( {
message: 'A new group',
group: 'something',
target: 'mw-js-message'
} );
// Clear the default group
// See code comments for more info
$.jsMessage( {
message: '',
replace: true,
target: 'mw-js-message'
} );
// Clear the 'something'-group
// Since this leaves no visible groups, the main box will hide (slideUp) right after
$.jsMessage( {
message: '',
group: 'something',
replace: true,
target: 'mw-js-message'
} );
If testing goes well, mw.util.jsMsg(message, className, replace) will call
$.jsMessage( { message: message, group: className, replace: replace, target: $.jsMessage(ge' );
So it's more a backend plugin, not used directly by core modules.
But this way extensions or third party sites can easily re-use this plugin and/or create multiple message boxes
on one page, by calling $.jsMessageNew and giving an id and location for it on the page.
Mark A. Hershberger [Fri, 4 Feb 2011 00:40:33 +0000 (00:40 +0000)]
Use the right query parameter.
Mark A. Hershberger [Fri, 4 Feb 2011 00:21:59 +0000 (00:21 +0000)]
re r81495 — you know, I've completely forgotten why I wanted to return a status object. Fix that and not the busted status message.
Happy-melon [Fri, 4 Feb 2011 00:20:14 +0000 (00:20 +0000)]
Revert r70270; per CR comments.
Mark A. Hershberger [Fri, 4 Feb 2011 00:15:44 +0000 (00:15 +0000)]
* make canCreateAccounts() return Status Objects instead of boolean
* re-use openConnection to test the ability of the user to connect.
Sam Reed [Thu, 3 Feb 2011 23:09:42 +0000 (23:09 +0000)]
Few more return types
Sam Reed [Thu, 3 Feb 2011 22:06:10 +0000 (22:06 +0000)]
Fixup r81467
Chad Horohoe [Thu, 3 Feb 2011 21:02:36 +0000 (21:02 +0000)]
rm unrelated changes from r81486
Chad Horohoe [Thu, 3 Feb 2011 21:01:35 +0000 (21:01 +0000)]
Remove now unused enableBackend()
Sam Reed [Thu, 3 Feb 2011 20:57:56 +0000 (20:57 +0000)]
Fix return type documentation
Sam Reed [Thu, 3 Feb 2011 20:47:54 +0000 (20:47 +0000)]
Fixup spaces to tabs
Chad Horohoe [Thu, 3 Feb 2011 20:40:20 +0000 (20:40 +0000)]
Raimond Spekking [Thu, 3 Feb 2011 19:50:35 +0000 (19:50 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-03 19:28:00 UTC)