From: Ævar Arnfjörð Bjarmason <avar@users.mediawiki.org>
Date: Fri, 29 Apr 2005 19:15:50 +0000 (+0000)
Subject: * Code cleanup
X-Git-Tag: 1.5.0alpha1~71
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=fd57e622388d86cf8de0d83fdf58e1b4191f7e75;p=lhc%2Fweb%2Fwiklou.git

* Code cleanup
---

diff --git a/includes/SpecialRandompage.php b/includes/SpecialRandompage.php
index f2cf40aae3..0cc945e527 100644
--- a/includes/SpecialRandompage.php
+++ b/includes/SpecialRandompage.php
@@ -16,7 +16,7 @@ function wfSpecialRandompage( $par = NS_MAIN ) {
 
 	# Determine the namespace to get a random page from.
 	$namespace = $wgContLang->getNsIndex($par);
-	if ($namespace === false || $namespace < NS_MAIN) {
+	if (!$namespace || $namespace < NS_MAIN) {
 		$namespace = NS_MAIN;
 	}
 	
@@ -36,18 +36,14 @@ function wfSpecialRandompage( $par = NS_MAIN ) {
 	$use_index = $db->useIndexClause( 'page_random' );
 	$page = $db->tableName( 'page' );
 
-	if ( $wgExtraRandompageSQL ) {
-		$extra = "AND ($wgExtraRandompageSQL)";
-	} else {
-		$extra = '';
-	}
-	$sqlget = "SELECT page_id,page_title
+	$extra = $wgExtraRandompageSQL ? "AND ($wgExtraRandompageSQL)" : '';
+	$sql = "SELECT page_id,page_title
 		FROM $page $use_index
-		WHERE page_namespace=".$namespace." AND page_is_redirect=0 $extra
+		WHERE page_namespace=$namespace AND page_is_redirect=0 $extra
 		AND page_random>$randstr
 		ORDER BY page_random
 		LIMIT 1";
-	$res = $db->query( $sqlget, $fname );
+	$res = $db->query( $sql, $fname );
 	
 	$title = null;
 	if( $s = $db->fetchObject( $res ) ) {