From: Stanislav Malyshev <smalyshev@gmail.com>
Date: Wed, 5 Sep 2018 22:00:25 +0000 (-0700)
Subject: Make assertFileContains not create files by default
X-Git-Tag: 1.34.0-rc.0~4166^2
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=fc202943abbf579898270e1269054906ccfdc4fc;p=lhc%2Fweb%2Fwiklou.git

Make assertFileContains not create files by default

This makes us miss test bugs like one in
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/458305

Change-Id: I2a96ed180be216aa615d8506999aa75f04c267bf
Depends-On: Ic85db75c2dba6c1c1fa6fd74dbea64f213609c0d
---

diff --git a/tests/phpunit/MediaWikiTestCase.php b/tests/phpunit/MediaWikiTestCase.php
index 69721655ce..29e98059f5 100644
--- a/tests/phpunit/MediaWikiTestCase.php
+++ b/tests/phpunit/MediaWikiTestCase.php
@@ -2278,7 +2278,7 @@ abstract class MediaWikiTestCase extends PHPUnit\Framework\TestCase {
 	protected function assertFileContains(
 		$fileName,
 		$actualData,
-		$createIfMissing = true,
+		$createIfMissing = false,
 		$msg = ''
 	) {
 		if ( $createIfMissing ) {