From: Tim Starling <tstarling@users.mediawiki.org>
Date: Mon, 29 Aug 2011 04:01:40 +0000 (+0000)
Subject: In Language::isValidBuiltInCode(), reject the empty string per Nikerabbit's request... 
X-Git-Tag: 1.31.0-rc.0~28032
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=ecd107afb2a62274050d2233130ae2254ec9cc87;p=lhc%2Fweb%2Fwiklou.git

In Language::isValidBuiltInCode(), reject the empty string per Nikerabbit's request on CR r82927. I'm not sure what the reason for the request was, but I suppose an empty language code could result in the base Language class being used, which could be problematic for some caller. It doesn't do any harm to reject it here.
---

diff --git a/languages/Language.php b/languages/Language.php
index 474fde02cd..49067be2cd 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -215,7 +215,7 @@ class Language {
 	 * @return bool
 	 */
 	public static function isValidBuiltInCode( $code ) {
-		return preg_match( '/^[a-z0-9-]*$/i', $code );
+		return preg_match( '/^[a-z0-9-]+$/i', $code );
 	}
 
 	public static function classFromCode( $code ) {