From: jenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Date: Fri, 5 Apr 2019 23:02:04 +0000 (+0000)
Subject: Merge "Fixes LocalFile isMissing always returning true"
X-Git-Tag: 1.34.0-rc.0~2139
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=bafee300f6200198246dbc645dcb57108c744cbd;hp=a44ae41d5806992c7b5524b8098022856f03f016;p=lhc%2Fweb%2Fwiklou.git

Merge "Fixes LocalFile isMissing always returning true"
---

diff --git a/includes/filerepo/file/LocalFile.php b/includes/filerepo/file/LocalFile.php
index 134a1045c1..aa04faec8f 100644
--- a/includes/filerepo/file/LocalFile.php
+++ b/includes/filerepo/file/LocalFile.php
@@ -796,11 +796,14 @@ class LocalFile extends File {
 	/** isVisible inherited */
 
 	/**
+	 * Checks if this file exists in its parent repo, as referenced by its
+	 * virtual URL.
+	 *
 	 * @return bool
 	 */
 	function isMissing() {
 		if ( $this->missing === null ) {
-			list( $fileExists ) = $this->repo->fileExists( $this->getVirtualUrl() );
+			$fileExists = $this->repo->fileExists( $this->getVirtualUrl() );
 			$this->missing = !$fileExists;
 		}