From: Ed Sanders <esanders@wikimedia.org>
Date: Thu, 14 Jun 2018 18:41:29 +0000 (+0100)
Subject: jqueryMsg: Add missing '$' prefix to jQuery collection variables
X-Git-Tag: 1.34.0-rc.0~5057
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=ab357da3c43c93c7809d613da5c60ffc1f1b2392;hp=1abf584017a839aff886457bf854e20b5842c7d0;p=lhc%2Fweb%2Fwiklou.git

jqueryMsg: Add missing '$' prefix to jQuery collection variables

Change-Id: Ic39ca379c373e43d885f6ac9df746e25f744f9d9
---

diff --git a/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js b/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js
index d81df65ebb..4f9e43a4cc 100644
--- a/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js
+++ b/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js
@@ -237,8 +237,8 @@
 	 * e.g.
 	 *
 	 *        $.fn.msg = mediaWiki.jqueryMsg.getPlugin( options );
-	 *        var userlink = $( '<a>' ).click( function () { alert( "hello!!" ) } );
-	 *        $( 'p#headline' ).msg( 'hello-user', userlink );
+	 *        var $userlink = $( '<a>' ).click( function () { alert( "hello!!" ) } );
+	 *        $( 'p#headline' ).msg( 'hello-user', $userlink );
 	 *
 	 * N.B. replacements are variadic arguments or an array in second parameter. In other words:
 	 *    somefunction( a, b, c, d )
@@ -1379,9 +1379,9 @@
 	 * @return {jQuery}
 	 */
 	mw.Message.prototype.parseDom = ( function () {
-		var reusableParent = $( '<div>' );
+		var $wrapper = $( '<div>' );
 		return function () {
-			return reusableParent.msg( this.key, this.parameters ).contents().detach();
+			return $wrapper.msg( this.key, this.parameters ).contents().detach();
 		};
 	}() );