From: Brion Vibber <brion@users.mediawiki.org>
Date: Wed, 5 Mar 2008 00:08:34 +0000 (+0000)
Subject: Add some debugging notes to User::isValidUserName() rejections
X-Git-Tag: 1.31.0-rc.0~49252
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=a8b32e0e3cdbd72ec26552f20fb7a38269eac6be;p=lhc%2Fweb%2Fwiklou.git

Add some debugging notes to User::isValidUserName() rejections
---

diff --git a/includes/User.php b/includes/User.php
index 08940a5ca2..10ccd4795d 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -424,16 +424,22 @@ class User {
 		|| User::isIP( $name )
 		|| strpos( $name, '/' ) !== false
 		|| strlen( $name ) > $wgMaxNameChars
-		|| $name != $wgContLang->ucfirst( $name ) )
+		|| $name != $wgContLang->ucfirst( $name ) ) {
+			wfDebugLog( 'username', __METHOD__ .
+				": '$name' invalid due to empty, IP, slash, length, or lowercase" );
 			return false;
+		}
 
 		// Ensure that the name can't be misresolved as a different title,
 		// such as with extra namespace keys at the start.
 		$parsed = Title::newFromText( $name );
 		if( is_null( $parsed )
 			|| $parsed->getNamespace()
-			|| strcmp( $name, $parsed->getPrefixedText() ) )
+			|| strcmp( $name, $parsed->getPrefixedText() ) ) {
+			wfDebugLog( 'username', __METHOD__ .
+				": '$name' invalid due to ambiguous prefixes" );
 			return false;
+		}
 		
 		// Check an additional blacklist of troublemaker characters.
 		// Should these be merged into the title char list?
@@ -446,6 +452,8 @@ class User {
 			'\x{e000}-\x{f8ff}' . # private use
 			']/u';
 		if( preg_match( $unicodeBlacklist, $name ) ) {
+			wfDebugLog( 'username', __METHOD__ .
+				": '$name' invalid due to blacklisted characters" );
 			return false;
 		}