From: Brian Wolff <bawolff@users.mediawiki.org>
Date: Wed, 12 May 2010 06:31:40 +0000 (+0000)
Subject: Special:Userrights didn't recognize user as self if person didn't capitalize
X-Git-Tag: 1.31.0-rc.0~36880
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=a80f428025003d7be531e40655625ddf85c29e89;p=lhc%2Fweb%2Fwiklou.git

Special:Userrights didn't recognize user as self if person didn't capitalize
the first letter of their name, and thus wouldn't honour $wgGroupsAddToSelf
if user accidently forgot to capitalize their name.

Possibly a regression from r57064
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index bfeed8a146..b76c611a29 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -162,6 +162,7 @@ in a negative namespace (which is invalid).
   MediaWiki:Subject-preview when previewing summary
 * (bug 23426) The {{REVISIONMONTH}} variable is now zero-padded and added new
   variable {{REVISIONMONTH1}} when unpadded version is needed.
+* Special:Userrights didn't recognize user as changing his/her own rights if user did not capitalize first letter of username.
 
 === API changes in 1.17 ===
 * (bug 22738) Allow filtering by action type on query=logevent
diff --git a/includes/specials/SpecialUserrights.php b/includes/specials/SpecialUserrights.php
index 1c58548c48..bec96ece2b 100644
--- a/includes/specials/SpecialUserrights.php
+++ b/includes/specials/SpecialUserrights.php
@@ -77,7 +77,7 @@ class UserrightsPage extends SpecialPage {
 				$this->mTarget = $wgUser->getName();
 		}
 
-		if ( $this->mTarget == $wgUser->getName() )
+		if ( User::getCanonicalName( $this->mTarget ) == $wgUser->getName() )
 			$this->isself = true;
 
 		if( !$this->userCanChangeRights( $wgUser, true ) ) {