From: Daniel Kinzler <daniel@users.mediawiki.org>
Date: Fri, 13 Nov 2009 22:09:42 +0000 (+0000)
Subject: use newer spec for html5 metadata
X-Git-Tag: 1.31.0-rc.0~38817
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=9e638dbef402377fb1c02f7228ec2fa611ee7aa0;p=lhc%2Fweb%2Fwiklou.git

use newer spec for html5 metadata
---

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 80b9a89da7..c8e55c4275 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -921,14 +921,15 @@ $wgHtml5 = true;
 $wgHtml5Version = null;
 
 /**
- * Enabled RDFa attributes for use in wikitext.
+ * Enabled RDFa attributes for use in wikitext. 
+ * NOTE: Interaction with HTML5 is somewhat underspecified.
  */
 $wgAllowRdfaAttributes = true;
 
 /**
- * Enabled HTML 5 data attributes for use in wikitext, if $wgHtml5 is also true.
+ * Enabled HTML 5 microdata attributes for use in wikitext, if $wgHtml5 is also true.
  */
-$wgAllowItemAttributes = true;
+$wgAllowMicrodataAttributes = true;
 
 /**
  * Should we try to make our HTML output well-formed XML?  If set to false,
diff --git a/includes/Sanitizer.php b/includes/Sanitizer.php
index d273d3816d..b1a3796b2b 100644
--- a/includes/Sanitizer.php
+++ b/includes/Sanitizer.php
@@ -650,11 +650,12 @@ class Sanitizer {
 					$wgEnforceHtmlIds ? 'noninitial' : 'xml' );
 			}
 
-			//RDFa and microdata properties allow URIs. check them
+			//RDFa and microdata properties allow URLs, URIs and/or CURIs. check them for sanity
 			if ( $attribute === 'rel' || $attribute === 'rev' || 
-				$attribute === 'about' || $attribute === 'property' || $attribute === 'resource' ||
-				$attribute === 'datatype' || $attribute === 'typeof' ||
-				$attribute === 'item' || $attribute === 'itemprop' || $attribute === 'subject' ) {  
+				$attribute === 'about' || $attribute === 'property' || $attribute === 'resource' || #RDFa
+				$attribute === 'datatype' || $attribute === 'typeof' ||                             #RDFa
+				$attribute === 'itemid' || $attribute === 'itemprop' || $attribute === 'itemref' || #HTML5 microdata
+				$attribute === 'itemscope' || $attribute === 'itemtype' ) {                         #HTML5 microdata
 
 				//Paranoia. Allow "simple" values but suppress javascript
 				if ( preg_match( MW_EVIL_URI_PATTERN, $value ) ) {
@@ -1199,7 +1200,7 @@ class Sanitizer {
 	 * @return Array
 	 */
 	static function setupAttributeWhitelist() {
-		global $wgAllowRdfaAttributes, $wgHtml5, $wgAllowItemAttributes;
+		global $wgAllowRdfaAttributes, $wgHtml5, $wgAllowMicrodataAttributes;
 
 		$common = array( 'id', 'class', 'lang', 'dir', 'title', 'style', 'xml:lang' );
 
@@ -1210,10 +1211,10 @@ class Sanitizer {
 			) );
 		}
 
-		if ( $wgHtml5 && $wgAllowItemAttributes ) {
-			# add HTML5 microdata tages as pecified by http://www.w3.org/TR/html5/microdata.html
+		if ( $wgHtml5 && $wgAllowMicrodataAttributes ) {
+			# add HTML5 microdata tages as pecified by http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#the-microdata-model
 			$common = array_merge( $common, array(
-			    'item', 'itemprop', 'subject'
+			    'itemid', 'itemprop', 'itemref', 'itemscope', 'itemtype'
 			) );
 		}