From: Catrope <roan.kattouw@gmail.com>
Date: Tue, 24 Jul 2012 20:29:04 +0000 (-0700)
Subject: Remove weird, confusing, unreachable code
X-Git-Tag: 1.31.0-rc.0~22970^2
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=972e5a3366ccfc0806bcc1b0e82c5ef39b800868;p=lhc%2Fweb%2Fwiklou.git

Remove weird, confusing, unreachable code

The removed code was doing first-order dependency resolution if a single
module was passed in as a string.

This is crazy because:
* passing in 'foo' triggered it but passing in ['foo'] didn't
* dependency resolution is resolve()'s responsibility
* all callers were passing in arrays produced by resolve(), so this code
  was never reached

Change-Id: I081e2bf90cead63437e495006c78254cf65e3847
---

diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js
index deb779594a..2332930912 100644
--- a/resources/mediawiki/mediawiki.js
+++ b/resources/mediawiki/mediawiki.js
@@ -880,15 +880,6 @@ var mw = ( function ( $, undefined ) {
 				// Allow calling by single module name
 				if ( typeof dependencies === 'string' ) {
 					dependencies = [dependencies];
-					if ( registry[dependencies[0]] !== undefined ) {
-						// Cache repetitively accessed deep level object member
-						regItemDeps = registry[dependencies[0]].dependencies;
-						// Cache to avoid looped access to length property
-						regItemDepLen = regItemDeps.length;
-						for ( n = 0; n < regItemDepLen; n += 1 ) {
-							dependencies[dependencies.length] = regItemDeps[n];
-						}
-					}
 				}
 
 				// Add ready and error callbacks if they were given