From: Brion Vibber <brion@users.mediawiki.org>
Date: Fri, 21 Aug 2009 21:26:34 +0000 (+0000)
Subject: No need to store the value of the magic quotes check here; just use a local var for... 
X-Git-Tag: 1.31.0-rc.0~40151
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=77f1f0ace74b2e36a366532b0532f7fec469e1e1;p=lhc%2Fweb%2Fwiklou.git

No need to store the value of the magic quotes check here; just use a local var for clarity.
---

diff --git a/includes/WebRequest.php b/includes/WebRequest.php
index 157f09305d..22057d40d8 100644
--- a/includes/WebRequest.php
+++ b/includes/WebRequest.php
@@ -44,7 +44,7 @@ if ( !function_exists( '__autoload' ) ) {
  */
 class WebRequest {
 	protected $data, $headers = array();
-	private $_response, $mFixMagicQuotes;
+	private $_response;
 
 	public function __construct() {
 		/// @fixme This preemptive de-quoting can interfere with other web libraries
@@ -179,8 +179,9 @@ class WebRequest {
 	 * time could damage the values.
 	 */
 	private function checkMagicQuotes() {
-		$this->mFixMagicQuotes = function_exists( 'get_magic_quotes_gpc' ) && get_magic_quotes_gpc();		
-		if( $this->mFixMagicQuotes ) {
+		$mustFixQuotes = function_exists( 'get_magic_quotes_gpc' )
+			&& get_magic_quotes_gpc();		
+		if( $mustFixQuotes ) {
 			$this->fix_magic_quotes( $_COOKIE );
 			$this->fix_magic_quotes( $_ENV );
 			$this->fix_magic_quotes( $_GET );