From: Brion Vibber <brion@users.mediawiki.org>
Date: Sun, 26 Oct 2008 01:47:07 +0000 (+0000)
Subject: Revert r42584 "Hook SkinTemplateTabAction now passes $title by reference allowing... 
X-Git-Tag: 1.31.0-rc.0~44583
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=29e82138985dd53c56f840b44ed19cb8ec4a4ebe;p=lhc%2Fweb%2Fwiklou.git

Revert r42584 "Hook SkinTemplateTabAction now passes $title by reference allowing it to be changed by extensions"
$title is used previous to this call, so that isn't an appropriate place to change it.
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 9fbe9c5b68..c431f8478b 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -175,8 +175,6 @@ The following extensions are migrated into MediaWiki 1.14:
 * Special:Wanted templates special page added to display missing templates
   linked from articles
 * Make search matches bold only, not red as well
-* Hook SkinTemplateTabAction now passes $title by reference allowing it to be 
-  changed by extensions.
 * Added 'UserRights::showEditUserGroupsForm' hook to allow extensions to alter
   the groups that the user can be added to or removed from in Special:UserRights
 
diff --git a/docs/hooks.txt b/docs/hooks.txt
index b4ea58783a..2c8e1746c0 100644
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -1175,7 +1175,7 @@ $out: Css to return
 'SkinTemplateTabAction': Override SkinTemplate::tabAction().
        You can either create your own array, or alter the parameters for the normal one.
 &$this:     The SkinTemplate instance.
-&$title:     Title instance for the page.
+$title:     Title instance for the page.
 $message:   Visible label of tab.
 $selected:  Whether this is a selected tab.
 $checkEdit: Whether or not the action=edit query should be added if appropriate.
diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index cae4073aa0..33307e3133 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -608,7 +608,7 @@ class SkinTemplate extends Skin {
 
 		$result = array();
 		if( !wfRunHooks('SkinTemplateTabAction', array(&$this,
-				&$title, $message, $selected, $checkEdit,
+				$title, $message, $selected, $checkEdit,
 				&$classes, &$query, &$text, &$result)) ) {
 			return $result;
 		}