From: Daniel Cannon <amidaniel@users.mediawiki.org>
Date: Tue, 27 Nov 2007 20:43:29 +0000 (+0000)
Subject: API: Another diff problem, var name mix-up.
X-Git-Tag: 1.31.0-rc.0~50699
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=1fac7474e4ba86baff56ba6abab99db632167ad2;p=lhc%2Fweb%2Fwiklou.git

API: Another diff problem, var name mix-up.
---

diff --git a/includes/api/ApiQueryRevisions.php b/includes/api/ApiQueryRevisions.php
index 51191d494e..d32afc9fb0 100644
--- a/includes/api/ApiQueryRevisions.php
+++ b/includes/api/ApiQueryRevisions.php
@@ -253,19 +253,21 @@ class ApiQueryRevisions extends ApiQueryBase {
 				$diff = new Diff($oldText, $newText);
 				$r['from'] = $previousRevID;
 				ApiResult::setContent($r, $wgContLang->unsegmentForDiff($this->formatter->format($diff)));
-				$diffArr[$revid] = $r;
+				$this->diffArr[$revid] = $r;
 								
 				$previousRevID = $revid;
 				$oldText = $newText;
 			}
 
-			# Populate the query result with the contents of $diffArr.
-			$knownrevs = array_keys($diffArr);
-			$i = count($knownrevs) - 1;
-			foreach($data['query']['pages'][$pageID]['revisions'] as &$rev) {
-				if ( $i >= 0 && isset ( $diffArr[$knownrevs[$i]] ) )
-					$rev['difftoprev'] = $diffArr[$knownrevs[$i]];
-				$i --;
+			if ( $this->diffArr ) {
+				# Populate the query result with the contents of $this->diffArr.
+				$knownrevs = array_keys($this->diffArr);
+				$i = count($knownrevs) - 1;
+				foreach($data['query']['pages'][$pageID]['revisions'] as &$rev) {
+					if ( $i >= 0 && isset ( $this->diffArr[$knownrevs[$i]] ) )
+						$rev['difftoprev'] = $this->diffArr[$knownrevs[$i]];
+					$i --;
+				}
 			}
 		}