From: Brion Vibber <brion@users.mediawiki.org>
Date: Mon, 25 Feb 2008 22:07:40 +0000 (+0000)
Subject: * (bug 12988) $wgMinimalPasswordLength no longer breaks create user by email
X-Git-Tag: 1.31.0-rc.0~49348
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=15f21f11125d5209ba6e088c71f74fa8699d02f0;p=lhc%2Fweb%2Fwiklou.git

* (bug 12988) $wgMinimalPasswordLength no longer breaks create user by email

The user password was being set to '-' briefly during setup, before being overwritten.
This broke with $wgMinimalPasswordLength > 1, throwing a fatal exception.
Using the special value of null instead allows the initial non-valid password entry to be set without hitting the minimum length.
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index ff506142be..d41b763279 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -42,6 +42,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 13140) Show parent categories in category namespace
 * (bug 13149) Correctly format 'fileexists' message on Upload page.
 * Make filepageexists accurate.
+* (bug 12988) $wgMinimalPasswordLength no longer breaks create user by email
 
 === API changes in 1.13 ===
 
diff --git a/includes/SpecialUserlogin.php b/includes/SpecialUserlogin.php
index 3651fdc8a2..88ad23604b 100644
--- a/includes/SpecialUserlogin.php
+++ b/includes/SpecialUserlogin.php
@@ -271,8 +271,8 @@ class LoginForm {
 				return false;
 			} else {
 				# do not force a password for account creation by email
-				# set pseudo password, it will be replaced later by a random generated password
-				$this->mPassword = '-';
+				# set invalid password, it will be replaced later by a random generated password
+				$this->mPassword = null;
 			}
 		}