From: Chad Horohoe <demon@users.mediawiki.org>
Date: Mon, 12 Jan 2009 23:58:07 +0000 (+0000)
Subject: Remove this ucfirst() crap. $filtered is already a DB key, so it should've been norma... 
X-Git-Tag: 1.31.0-rc.0~43448
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=1133ba2d29bf468ca112a3f7aa04d92973e6515f;p=lhc%2Fweb%2Fwiklou.git

Remove this ucfirst() crap. $filtered is already a DB key, so it should've been normalized at Title construction anyway (and if it wasn't, that's Title's fault). Fwiw: we're throwing a dismissable error every time $wgCapitalLinks is enabled and a lowercase name is submitted. Why bother? We handle this silently everywhere else...
---

diff --git a/includes/specials/SpecialUpload.php b/includes/specials/SpecialUpload.php
index 3e2c02ad62..51f31c4155 100644
--- a/includes/specials/SpecialUpload.php
+++ b/includes/specials/SpecialUpload.php
@@ -508,11 +508,6 @@ class UploadForm {
 				$warning .=  '<li>'.wfMsgHtml( 'badfilename', htmlspecialchars( $this->mDestName ) ).'</li>';
 			}
 
-			global $wgCapitalLinks;
-			if( $wgCapitalLinks ) {
-				$filtered = ucfirst( $filtered );
-			}
-
 			global $wgCheckFileExtensions;
 			if ( $wgCheckFileExtensions ) {
 				if ( !$this->checkFileExtension( $finalExt, $wgFileExtensions ) ) {