From: Brion Vibber <brion@users.mediawiki.org>
Date: Sat, 18 Jun 2005 09:55:17 +0000 (+0000)
Subject: Code cleanup: initialize the array variable rather than covering up an uninitialized... 
X-Git-Tag: 1.5.0beta1~162
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=104be1a92466a8cda27e8361716e49e626891de2;p=lhc%2Fweb%2Fwiklou.git

Code cleanup: initialize the array variable rather than covering up an uninitialized use...
---

diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index d57b6a8f66..a31759948f 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -718,6 +718,7 @@ class SkinTemplate extends Skin {
 		$fname = 'SkinTemplate::buildSidebar';
 		wfProfileIn( $fname );
 		
+		$bar = array();
 		$lines = explode( "\n", wfMsgForContent( 'sidebar' ) );
 		foreach ($lines as $line) {
 			if (strpos($line, '*') !== 0)
@@ -738,9 +739,7 @@ class SkinTemplate extends Skin {
 		}
 		
 		wfProfileOut( $fname );
-		// Warnings off in case $bar wasn't created above (bogus input, or maybe
-		// they just don't want a sidebar)
-		return @$bar;
+		return $bar;
 	}
 
 	/**