From: Platonides <platonides@users.mediawiki.org>
Date: Tue, 26 Oct 2010 15:14:56 +0000 (+0000)
Subject: Cache the results of wfIsWindows()
X-Git-Tag: 1.31.0-rc.0~34299
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=0b7e7be4ccb12e4e4125bb51726b319948e620f8;p=lhc%2Fweb%2Fwiklou.git

Cache the results of wfIsWindows()
Each php_uname() call produces a uname syscall.

The cached one is three times faster (3.197545885) which is liklely to be the difference between a php var lookup and a syscall on my system.

== Test script ==
<?php

function wfIsWindows() {
	if ( substr( php_uname(), 0, 7 ) == 'Windows' ) {
		return true;
	} else {
		return false;
	}
}

function wfIsWindowsCached() {
	static $isWindows = null;
	if ( $isWindows === null ) {
		$isWindows = substr( php_uname(), 0, 7 ) == 'Windows';
	}
	return $isWindows;
}


$win = $nonwin = 0;

$time = microtime( true );
for ( $i = 1; $i < 5e8; $i++ ) {
	if ( wfIsWindowsCached() ) {
		$win++;
	} else {
		$nonwin++;
	}
}

$time = microtime( true ) - $time;
echo "Time elapsed: $time\n";
---

diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index d0479229e7..acbde8fceb 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -2068,11 +2068,11 @@ function wfTimestampOrNull( $outputtype = TS_UNIX, $ts = null ) {
  * @return Bool: true if it's Windows, False otherwise.
  */
 function wfIsWindows() {
-	if ( substr( php_uname(), 0, 7 ) == 'Windows' ) {
-		return true;
-	} else {
-		return false;
+	static $isWindows = null;
+	if ( $isWindows === null ) {
+		$isWindows = substr( php_uname(), 0, 7 ) == 'Windows';
 	}
+	return $isWindows;
 }
 
 /**