Always return bool in BackupReader::handleUpload
authorumherirrender <umherirrender_de.wp@web.de>
Mon, 21 Jul 2014 09:32:34 +0000 (11:32 +0200)
committerumherirrender <umherirrender_de.wp@web.de>
Mon, 21 Jul 2014 09:32:57 +0000 (11:32 +0200)
Change-Id: I476a1668b3a1ff9148ff335c9d7c9aa0c8ca3d11

maintenance/importDump.php

index 1f7cbf5..1fedefb 100644 (file)
@@ -182,7 +182,7 @@ TEXT;
        function handleUpload( $revision ) {
                if ( $this->uploads ) {
                        if ( $this->skippedNamespace( $revision ) ) {
-                               return;
+                               return false;
                        }
                        $this->uploadCount++;
                        // $this->report();
@@ -196,6 +196,8 @@ TEXT;
                                return $dbw->deadlockLoop( array( $revision, 'importUpload' ) );
                        }
                }
+
+               return false;
        }
 
        function handleLogItem( $rev ) {