Start yelling if a job's run() does not return bool

Change-Id: Ia31be9cc5bac1427225c993911a1f77e8654f778

diff --git a/maintenance/runJobs.php b/maintenance/runJobs.php
index a78acd5..3fc9288 100644 (file)
--- a/maintenance/runJobs.php
+++ b/maintenance/runJobs.php
@@ -91,6 +91,11 @@ class RunJobs extends Maintenance {
                                $t = microtime( true );
                                $this->runJobsLog( $job->toString() . " STARTING" );
                                $status = $job->run();
+
+                               if( !is_bool( $status ) ) {
+                                       wfWarn( $job->toString() . ' must return boolean and didn\'t!'  );
+                               }
+
                                if ( $status ) {
                                        $group->ack( $job ); // done
                                }