shell script fix using shellcheck lint

* shellcheck script used: https://github.com/koalaman/shellcheck
* includes/php.sh: Use $(..) instead of deprecated `..`.

Change-Id: Ie1dfff97b548aca75d76c762b74f8fcab84d46fb

diff --git a/maintenance/dev/includes/php.sh b/maintenance/dev/includes/php.sh
index 7ce8794..3c5bef0 100644 (file)
--- a/maintenance/dev/includes/php.sh
+++ b/maintenance/dev/includes/php.sh
@@ -4,7 +4,7 @@
 # and previous home directory location
 # The binary path is returned in $PHP if any
 
-for binary in $PHP `which php || true` "$DEV/php/bin/php" "$HOME/.mediawiki/php/bin/php" "$HOME/.mwphp/bin/php" ]; do
+for binary in $PHP $(which php || true) "$DEV/php/bin/php" "$HOME/.mediawiki/php/bin/php" "$HOME/.mwphp/bin/php" ]; do
        if [ -x "$binary" ]; then
                if "$binary" -r 'exit((int)!version_compare(PHP_VERSION, "5.4", ">="));'; then
                        PHP="$binary"