Avoid page table query spam in HistoryPager due to lastLink()
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 13 Mar 2019 18:31:58 +0000 (11:31 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 13 Mar 2019 18:31:58 +0000 (11:31 -0700)
Pass in the Title so there is not an extra query for each revision.

Change-Id: I0d36422a304c31c4bda0a408ef4a6fcd52ad57f1

includes/Title.php
includes/actions/pagers/HistoryPager.php

index 82e79b3..9161733 100644 (file)
@@ -437,6 +437,7 @@ class Title implements LinkTarget, IDBAccessObject {
                } else {
                        $title = null;
                }
+
                return $title;
        }
 
index a59597f..d3a32d0 100644 (file)
@@ -541,7 +541,7 @@ class HistoryPager extends ReverseChronologicalPager {
                        );
                }
 
-               $nextRev = new Revision( $next );
+               $nextRev = new Revision( $next, 0, $this->getTitle() );
 
                if ( !$prevRev->userCan( Revision::DELETED_TEXT, $this->getUser() )
                        || !$nextRev->userCan( Revision::DELETED_TEXT, $this->getUser() )