Declare visibility for class properties in DatabaseMssql
authorSiebrand Mazeland <s.mazeland@xs4all.nl>
Fri, 27 Dec 2013 00:45:19 +0000 (01:45 +0100)
committerSiebrand <siebrand@wikimedia.org>
Fri, 27 Dec 2013 09:25:15 +0000 (09:25 +0000)
Change-Id: Icf0209a1f1f601a50dbc1e8cf59ca0b8afabd40f

includes/db/DatabaseMssql.php

index 5a5eab1..96b4c15 100644 (file)
  * @ingroup Database
  */
 class DatabaseMssql extends DatabaseBase {
-       var $mInsertId = null;
-       var $mLastResult = null;
-       var $mAffectedRows = null;
+       /** @var resource */
+       protected $mLastResult = null;
 
-       var $mPort;
+       /** @var int The number of rows affected as an integer */
+       protected $mAffectedRows = null;
+
+       /**
+        * @var int Post number for database
+        * @todo Unused and can be removed?
+        */
+       protected $mPort;
+
+       /** @var int */
+       private $mInsertId = null;
 
        function cascadingDeletes() {
                return true;
@@ -271,7 +280,7 @@ class DatabaseMssql extends DatabaseBase {
 
        /**
         * This must be called after nextSequenceVal
-        * @return null
+        * @return int|null
         */
        function insertId() {
                return $this->mInsertId;