Fix r46628 -- I'd misunderstood the nature of the hack. People wanted to append the...

diff --git a/includes/parser/CoreParserFunctions.php b/includes/parser/CoreParserFunctions.php
index 1045fad..fba3d5f 100644 (file)
--- a/includes/parser/CoreParserFunctions.php
+++ b/includes/parser/CoreParserFunctions.php
@@ -381,7 +381,11 @@ class CoreParserFunctions {
        static function pad( $string, $length, $padding = '0', $direction = STR_PAD_RIGHT ) {
                $lengthOfPadding = mb_strlen( $padding );               
                if ( $lengthOfPadding == 0 ) return $string;
-               if ( $length < mb_strlen( $string ) ) return $string;
+
+               // Thwart attempts to use this function to truncate strings.
+               //  We don't want people implementing ParserFunctions in template,
+               //  for performance and usability reasons.
+               if ($lengthOfPadding > $length && $string == '') return $string;
                
                # The remaining length to add counts down to 0 as padding is added
                $length = min( $length, 500 ) - mb_strlen( $string );