strpos() !== false is faster than strstr()

diff --git a/includes/ImagePage.php b/includes/ImagePage.php
index d93436e..66e8ba6 100644 (file)
--- a/includes/ImagePage.php
+++ b/includes/ImagePage.php
@@ -554,7 +554,7 @@ EOT
                                $wgOut->showUnexpectedValueError( 'oldimage', htmlspecialchars($oldimage) );
                                return;
                        }
-                       if ( strstr( $oldimage, "/" ) || strstr( $oldimage, "\\" ) ) {
+                       if( strpos( $oldimage, '/' ) !== false || strpos( $oldimage, '\\' ) !== false ) {
                                $wgOut->showUnexpectedValueError( 'oldimage', htmlspecialchars($oldimage) );
                                return;
                        }