Special:Userrights didn't recognize user as self if person didn't capitalize

the first letter of their name, and thus wouldn't honour $wgGroupsAddToSelf
if user accidently forgot to capitalize their name.

Possibly a regression from r57064

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index bfeed8a..b76c611 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -162,6 +162,7 @@ in a negative namespace (which is invalid).
   MediaWiki:Subject-preview when previewing summary
 * (bug 23426) The {{REVISIONMONTH}} variable is now zero-padded and added new
   variable {{REVISIONMONTH1}} when unpadded version is needed.
+* Special:Userrights didn't recognize user as changing his/her own rights if user did not capitalize first letter of username.
 
 === API changes in 1.17 ===
 * (bug 22738) Allow filtering by action type on query=logevent

diff --git a/includes/specials/SpecialUserrights.php b/includes/specials/SpecialUserrights.php
index 1c58548..bec96ec 100644 (file)
--- a/includes/specials/SpecialUserrights.php
+++ b/includes/specials/SpecialUserrights.php
@@ -77,7 +77,7 @@ class UserrightsPage extends SpecialPage {
                                $this->mTarget = $wgUser->getName();
                }
 
-               if ( $this->mTarget == $wgUser->getName() )
+               if ( User::getCanonicalName( $this->mTarget ) == $wgUser->getName() )
                        $this->isself = true;
 
                if( !$this->userCanChangeRights( $wgUser, true ) ) {