(bug 16044) Vague error message in Special:Emailuser
authorAaron Schulz <aaron@users.mediawiki.org>
Fri, 2 Jan 2009 22:14:54 +0000 (22:14 +0000)
committerAaron Schulz <aaron@users.mediawiki.org>
Fri, 2 Jan 2009 22:14:54 +0000 (22:14 +0000)
includes/specials/SpecialEmailuser.php

index 1556820..b653bdb 100644 (file)
@@ -268,9 +268,15 @@ class EmailUserForm {
                }
        
                $nu = User::newFromName( $nt->getText() );
-               if( is_null( $nu ) || !$nu->canReceiveEmail() ) {
-                       wfDebug( "Target is invalid user or can't receive.\n" );
+               if( is_null( $nu ) ) {
+                       wfDebug( "Target is invalid user.\n" );
+                       return "notarget";
+               } else if ( !$nu->isEmailConfirmed() ) {
+                       wfDebug( "User has no valid email.\n" );
                        return "noemail";
+               } else if ( !$nu->canReceiveEmail() ) {
+                       wfDebug( "User does not allow user emails.\n" );
+                       return "nowikiemail";
                }
                
                return $nu;