Change various uses of GROUP BY 1,2,3 and similar to use the actual column names...

This should cause no functional changes.  If it does, revert.

diff --git a/includes/specials/SpecialFewestrevisions.php b/includes/specials/SpecialFewestrevisions.php
index fb23bb9..afd5ad4 100644 (file)
--- a/includes/specials/SpecialFewestrevisions.php
+++ b/includes/specials/SpecialFewestrevisions.php
@@ -36,7 +36,7 @@ class FewestrevisionsPage extends QueryPage {
                        FROM $revision
                        JOIN $page ON page_id = rev_page
                        WHERE page_namespace = " . NS_MAIN . "
-                       GROUP BY 1,2,3,4
+                       GROUP BY page_namespace, page_title, page_is_redirect
                        HAVING COUNT(*) > 1";
                        // ^^^ This was probably here to weed out redirects.
                        // Since we mark them as such now, it might be

diff --git a/includes/specials/SpecialMostcategories.php b/includes/specials/SpecialMostcategories.php
index 5df9c86..e681099 100644 (file)
--- a/includes/specials/SpecialMostcategories.php
+++ b/includes/specials/SpecialMostcategories.php
@@ -31,7 +31,7 @@ class MostcategoriesPage extends QueryPage {
                        FROM $categorylinks
                        LEFT JOIN $page ON cl_from = page_id
                        WHERE page_namespace = " . NS_MAIN . "
-                       GROUP BY 1,2,3
+                       GROUP BY page_namespace, page_title
                        HAVING COUNT(*) > 1
                        ";
        }

diff --git a/includes/specials/SpecialMostimages.php b/includes/specials/SpecialMostimages.php
index 2fed0bd..6cfeb7a 100644 (file)
--- a/includes/specials/SpecialMostimages.php
+++ b/includes/specials/SpecialMostimages.php
@@ -29,7 +29,7 @@ class MostimagesPage extends ImageQueryPage {
                                il_to as title,
                                COUNT(*) as value
                        FROM $imagelinks
-                       GROUP BY 1,2,3
+                       GROUP BY il_to
                        HAVING COUNT(*) > 1
                        ";
        }

diff --git a/includes/specials/SpecialMostlinked.php b/includes/specials/SpecialMostlinked.php
index a56ac26..078489b 100644 (file)
--- a/includes/specials/SpecialMostlinked.php
+++ b/includes/specials/SpecialMostlinked.php
@@ -36,7 +36,7 @@ class MostlinkedPage extends QueryPage {
                                page_namespace
                        FROM $pagelinks
                        LEFT JOIN $page ON pl_namespace=page_namespace AND pl_title=page_title
-                       GROUP BY 1,2,3,5
+                       GROUP BY pl_namespace, pl_title, page_namespace
                        HAVING COUNT(*) > 1";
        }
 

diff --git a/includes/specials/SpecialMostlinkedcategories.php b/includes/specials/SpecialMostlinkedcategories.php
index 1b66d48..ab25067 100644 (file)
--- a/includes/specials/SpecialMostlinkedcategories.php
+++ b/includes/specials/SpecialMostlinkedcategories.php
@@ -31,7 +31,7 @@ class MostlinkedCategoriesPage extends QueryPage {
                                cl_to as title,
                                COUNT(*) as value
                        FROM $categorylinks
-                       GROUP BY 1,2,3
+                       GROUP BY cl_to
                        ";
        }
 

diff --git a/includes/specials/SpecialMostlinkedtemplates.php b/includes/specials/SpecialMostlinkedtemplates.php
index b8d47e6..d597a4e 100644 (file)
--- a/includes/specials/SpecialMostlinkedtemplates.php
+++ b/includes/specials/SpecialMostlinkedtemplates.php
@@ -64,7 +64,7 @@ class SpecialMostlinkedtemplates extends QueryPage {
                        COUNT(*) AS value
                        FROM {$templatelinks}
                        WHERE tl_namespace = " . NS_TEMPLATE . "
-                       GROUP BY 1, 2, 3";
+                       GROUP BY tl_title";
        }
 
        /**

diff --git a/includes/specials/SpecialMostrevisions.php b/includes/specials/SpecialMostrevisions.php
index 001a08b..f5a0f8c 100644 (file)
--- a/includes/specials/SpecialMostrevisions.php
+++ b/includes/specials/SpecialMostrevisions.php
@@ -31,7 +31,7 @@ class MostrevisionsPage extends QueryPage {
                        FROM $revision
                        JOIN $page ON page_id = rev_page
                        WHERE page_namespace = " . NS_MAIN . "
-                       GROUP BY 1,2,3
+                       GROUP BY page_namespace, page_title
                        HAVING COUNT(*) > 1
                        ";
        }

diff --git a/includes/specials/SpecialWantedcategories.php b/includes/specials/SpecialWantedcategories.php
index 969a8d8..7497f9b 100644 (file)
--- a/includes/specials/SpecialWantedcategories.php
+++ b/includes/specials/SpecialWantedcategories.php
@@ -41,7 +41,7 @@ class WantedCategoriesPage extends QueryPage {
                        FROM $categorylinks
                        LEFT JOIN $page ON cl_to = page_title AND page_namespace = ". NS_CATEGORY ."
                        WHERE page_title IS NULL
-                       GROUP BY 1,2,3
+                       GROUP BY cl_to
                        ";
        }
 

diff --git a/includes/specials/SpecialWantedpages.php b/includes/specials/SpecialWantedpages.php
index 650e04f..1013340 100644 (file)
--- a/includes/specials/SpecialWantedpages.php
+++ b/includes/specials/SpecialWantedpages.php
@@ -44,7 +44,7 @@ class WantedPagesPage extends QueryPage {
                         WHERE pg1.page_namespace IS NULL
                         AND pl_namespace NOT IN ( 2, 3 )
                         AND pg2.page_namespace != 8
-                        GROUP BY 1,2,3
+                        GROUP BY pl_namespace, pl_title
                         HAVING COUNT(*) > $count";
        }