Fix for r51493, r51084 and realted: use Title::makeTitle() rather than Title::newFrom...

diff --git a/includes/Article.php b/includes/Article.php
index b1213fd..f3aa9af 100644 (file)
--- a/includes/Article.php
+++ b/includes/Article.php
@@ -2467,7 +2467,7 @@ class Article {
 
                        if( $wgUser->isAllowed( 'editinterface' ) ) {
                                $skin = $wgUser->getSkin();
-                               $title = Title::newFromText( 'Deletereason-dropdown', NS_MEDIAWIKI );
+                               $title = Title::makeTitle( NS_MEDIAWIKI, 'Deletereason-dropdown' );
                                $link = $skin->link(
                                        $title,
                                        wfMsgHtml( 'delete-edit-reasonlist' ),

diff --git a/includes/FileDeleteForm.php b/includes/FileDeleteForm.php
index a958364..b89a5e9 100644 (file)
--- a/includes/FileDeleteForm.php
+++ b/includes/FileDeleteForm.php
@@ -194,7 +194,7 @@ class FileDeleteForm {
 
                        if ( $wgUser->isAllowed( 'editinterface' ) ) {
                                $skin = $wgUser->getSkin();
-                               $title = Title::newFromText( 'Filedelete-reason-dropdown', NS_MEDIAWIKI );
+                               $title = Title::makeTitle( NS_MEDIAWIKI, 'Filedelete-reason-dropdown' );
                                $link = $skin->link(
                                        $title,
                                        wfMsgHtml( 'filedelete-edit-reasonlist' ),

diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php
index b1f7d65..e4ca0d7 100644 (file)
--- a/includes/ProtectionForm.php
+++ b/includes/ProtectionForm.php
@@ -447,7 +447,7 @@ class ProtectionForm {
                $out .= Xml::closeElement( 'fieldset' );
 
                if ( $wgUser->isAllowed( 'editinterface' ) ) {
-                       $title = Title::newFromText( 'Protect-dropdown', NS_MEDIAWIKI );
+                       $title = Title::makeTitle( NS_MEDIAWIKI, 'Protect-dropdown' );
                        $link = $wgUser->getSkin()->link(
                                $title,
                                wfMsgHtml( 'protect-edit-reasonlist' ),

diff --git a/includes/specials/SpecialBlockip.php b/includes/specials/SpecialBlockip.php
index 488c559..933924f 100644 (file)
--- a/includes/specials/SpecialBlockip.php
+++ b/includes/specials/SpecialBlockip.php
@@ -636,7 +636,7 @@ class IPBlockForm {
                        $links[] = $this->getContribsLink( $skin );
                $links[] = $this->getUnblockLink( $skin );
                $links[] = $this->getBlockListLink( $skin );
-               $title = Title::newFromText( 'Ipbreason-dropdown', NS_MEDIAWIKI );
+               $title = Title::makeTitle( NS_MEDIAWIKI, 'Ipbreason-dropdown' );
                $links[] = $skin->link(
                        $title,
                        wfMsgHtml( 'ipb-edit-dropdown' ),