(bug 23923) Special:Prefixindex no longer shows results if nothing was requested.

I believe that this was the intention of the original code anyway, but isset was used on places where it should not have been.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 81594ba..c8e8209 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -362,6 +362,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   available via the API
 * (bug 23934) Groups defined in $wgRevokePermissions but not in
   $wgGroupPermissions now appear on Special:ListGroupRights
+* (bug 23923) Special:Prefixindex no longer shows results if nothing was
+  requested.
 
 === API changes in 1.17 ===
 * (bug 22738) Allow filtering by action type on query=logevent.

diff --git a/includes/specials/SpecialPrefixindex.php b/includes/specials/SpecialPrefixindex.php
index 874d755..dbf47ed 100644 (file)
--- a/includes/specials/SpecialPrefixindex.php
+++ b/includes/specials/SpecialPrefixindex.php
@@ -44,7 +44,7 @@ class SpecialPrefixindex extends SpecialAllpages {
                $this->outputHeader();
 
                # GET values
-               $from = $wgRequest->getVal( 'from' );
+               $from = $wgRequest->getVal( 'from', '' );
                $prefix = $wgRequest->getVal( 'prefix', '' );
                $namespace = $wgRequest->getInt( 'namespace' );
                $namespaces = $wgContLang->getNamespaces();
@@ -56,9 +56,9 @@ class SpecialPrefixindex extends SpecialAllpages {
 
                if( isset( $par ) ){
                        $this->showPrefixChunk( $namespace, $par, $from );
-               } elseif( isset( $prefix ) ){
+               } elseif( $prefix ){
                        $this->showPrefixChunk( $namespace, $prefix, $from );
-               } elseif( isset( $from ) ){
+               } elseif( $from ){
                        $this->showPrefixChunk( $namespace, $from, $from );
                } else {
                        $wgOut->addHTML( $this->namespacePrefixForm( $namespace, null ) );