Explicitally define variables

diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php
index 63bcfb6..c06b769 100644 (file)
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -25,8 +25,16 @@ class DifferenceEngine {
        var $mOldid, $mNewid, $mTitle;
        var $mOldtitle, $mNewtitle, $mPagetitle;
        var $mOldtext, $mNewtext;
+
+       /**
+        * @var Title
+        */
        var $mOldPage, $mNewPage;
        var $mRcidMarkPatrolled;
+
+       /**
+        * @var Revision
+        */
        var $mOldRev, $mNewRev;
        var $mRevisionsLoaded = false; // Have the revisions been loaded
        var $mTextLoaded = 0; // How many text blobs have been loaded, 0, 1 or 2?
@@ -401,6 +409,10 @@ CONTROL;
                wfProfileOut( __METHOD__ );
        }
 
+       /**
+        * @param $rev Revision
+        * @return String
+        */
        protected function revisionDeleteLink( $rev ) {
                global $wgUser;
                $link = '';

diff --git a/includes/diff/WikiDiff.php b/includes/diff/WikiDiff.php
index 3c31119..1f88192 100644 (file)
--- a/includes/diff/WikiDiff.php
+++ b/includes/diff/WikiDiff.php
@@ -137,6 +137,13 @@ class _DiffEngine {
 
        protected $xchanged, $ychanged;
 
+       protected $xv = array(), $yv = array();
+       protected $xind = array(), $yind = array();
+
+       protected $seq = array(), $in_seq = array();
+
+       protected $lcs = 0;
+
        function diff ( $from_lines, $to_lines ) {
                wfProfileIn( __METHOD__ );
 
@@ -841,8 +848,7 @@ class DiffFormatter {
                                        }
                                }
                                $context = $edit->orig;
-                       }
-                       else {
+                       } else {
                                if ( ! is_array( $block ) ) {
                                        $context = array_slice( $context, sizeof( $context ) - $nlead );
                                        $x0 = $xi - sizeof( $context );