Currently, we do not send last-modified headers for the RC if patrolling is in use...

see patrol marks.

As an aside, Special:Recentchanges does not show new page patrol marks
if $wgUseNPPatrol = true, but $wgUseRCPatrol=false (it only shows them if
both are true), where Special:newpages shows patrol stuff whenever $wgUseNPPatrol
is true, regardless of $wgUseRCPatrol. Which is a tad weird, but whatever.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 07b19da..8842420 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -113,6 +113,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   is blacklisted now gives the proper extension in the error message.
 * (bug 26961) Hide anon edits in watchlist preference now actually works.
 * (bug 19751) Filesystem is now checked during image undeletion
+* Send last modified headers for Special:Recentchanges when RC patrol is
+  enabled, but user cannot see rc patrol links.
 
 === API changes in 1.18 ===
 * (bug 26339) Throw warning when truncating an overlarge API result

diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php
index 2f13fe5..3ec4ae4 100644 (file)
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -210,10 +210,10 @@ class SpecialRecentChanges extends IncludableSpecialPage {
         * @return String or false
         */
        public function checkLastModified( $feedFormat ) {
-               global $wgUseRCPatrol, $wgOut;
+               global $wgOut, $wgUser;
                $dbr = wfGetDB( DB_SLAVE );
                $lastmod = $dbr->selectField( 'recentchanges', 'MAX(rc_timestamp)', false, __METHOD__ );
-               if( $feedFormat || !$wgUseRCPatrol ) {
+               if( $feedFormat || !$wgUser->useRCPatrol() ) {
                        if( $lastmod && $wgOut->checkLastModified( $lastmod ) ) {
                                # Client cache fresh and headers sent, nothing more to do.
                                return false;