Use OldLocalFile::selectFields()
authorumherirrender <umherirrender_de.wp@web.de>
Sat, 9 Feb 2013 15:12:09 +0000 (16:12 +0100)
committerumherirrender <umherirrender_de.wp@web.de>
Sat, 9 Feb 2013 15:12:09 +0000 (16:12 +0100)
It is good practice to specifiy the fields in a select

Change-Id: I3faa568ed6311a585da9161eccd8da3d065da250

includes/revisiondelete/RevisionDelete.php

index 5340cb9..bd909d2 100644 (file)
@@ -454,7 +454,9 @@ class RevDel_FileList extends RevDel_List {
                foreach( $this->ids as $timestamp ) {
                        $archiveNames[] = $timestamp . '!' . $this->title->getDBkey();
                }
-               return $db->select( 'oldimage', '*',
+               return $db->select(
+                       'oldimage',
+                       OldLocalFile::selectFields(),
                        array(
                                'oi_name'         => $this->title->getDBkey(),
                                'oi_archive_name' => $archiveNames