Fail fast if given invalid input. We've had some of these in the past and they were...

diff --git a/includes/MessageCache.php b/includes/MessageCache.php
index 164ff62..fda8181 100644 (file)
--- a/includes/MessageCache.php
+++ b/includes/MessageCache.php
@@ -499,6 +499,10 @@ class MessageCache {
        function get( $key, $useDB = true, $langcode = true, $isFullKey = false ) {
                global $wgContLanguageCode, $wgContLang;
 
+               if ( !is_string( $key ) ) {
+                       throw new MWException( "Non-string key given" );
+               }
+
                if ( strval( $key ) === '' ) {
                        # Shortcut: the empty key is always missing
                        return false;