[JobQueue] Cleaned up DuplicateJob factory function.
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 18 Dec 2012 01:11:15 +0000 (17:11 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 18 Dec 2012 01:11:15 +0000 (17:11 -0800)
Change-Id: If2303776bdbc9b78a07907e7b290c2da5af7e493

includes/job/jobs/DuplicateJob.php

index 6e056de..23418e3 100644 (file)
@@ -45,11 +45,11 @@ final class DuplicateJob extends Job {
         * @return Job
         */
        public static function newFromJob( Job $job ) {
-               $job = new self( $job->getTitle(), $job->getParams(), $job->getId() );
-               $job->command = $job->getType();
-               $job->params  = is_array( $job->params ) ? $job->params : array();
-               $job->params  = array( 'isDuplicate' => true ) + $job->params;
-               return $job;
+               $djob = new self( $job->getTitle(), $job->getParams(), $job->getId() );
+               $djob->command = $job->getType();
+               $djob->params  = is_array( $djob->params ) ? $djob->params : array();
+               $djob->params  = array( 'isDuplicate' => true ) + $djob->params;
+               return $djob;
        }
 
        public function run() {