* (bug 3218) Use proper quoting on history Compare Revisions button

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 05aa2fd..a841a47 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -42,6 +42,7 @@ Misc work going on.....
 * (bug 3210) Fix Media: links with remote image URL path
 * (bug 1956) Hide bot uploads from Special:Newimages
 * (bug 3216) Don't show empty warning page when no warnings.
+* (bug 3218) Use proper quoting on history Compare Revisions button
 
 
 === Caveats ===

diff --git a/includes/PageHistory.php b/includes/PageHistory.php
index a3d6c28..a774248 100644 (file)
--- a/includes/PageHistory.php
+++ b/includes/PageHistory.php
@@ -186,7 +186,7 @@ class PageHistory {
                $s = wfMsgWikiHtml( 'histlegend' );
                $s .= '<form action="' . $wgTitle->escapeLocalURL( '-' ) . '" method="get">';
                $prefixedkey = htmlspecialchars($wgTitle->getPrefixedDbKey());
-               $s .= "<input type='hidden' name='title' value='{$prefixedkey}' />\n";
+               $s .= "<input type='hidden' name='title' value=\"{$prefixedkey}\" />\n";
                $s .= $this->submitButton();
                $s .= '<ul id="pagehistory">' . "\n";
                return $s;