Followup r95458

Add a couple of bits of documentation

Removed an unused global

No need to 1.18 this

diff --git a/maintenance/refreshImageMetadata.php b/maintenance/refreshImageMetadata.php
index ec61218..9b732ed 100644 (file)
--- a/maintenance/refreshImageMetadata.php
+++ b/maintenance/refreshImageMetadata.php
@@ -156,6 +156,10 @@ class RefreshImageMetadata extends Maintenance {
                }
        }
 
+       /**
+        * @param $dbw DatabaseBase
+        * @return array
+        */
        function getConditions( $dbw ) {
                $conds = array();
 
@@ -179,8 +183,12 @@ class RefreshImageMetadata extends Maintenance {
                return $conds;
        }
 
+       /**
+        * @param $force bool
+        * @param $brokenOnly bool
+        */
        function setupParameters( $force, $brokenOnly ) {
-               global $wgUpdateCompatibleMetadata, $wgReadOnly;
+               global $wgUpdateCompatibleMetadata;
 
                if ( $brokenOnly ) {
                        $wgUpdateCompatibleMetadata = false;