Fixed double-escaping bug in ConfEditor's handling of double-quoted strings.
authorBrion Vibber <brion@users.mediawiki.org>
Fri, 14 Aug 2009 00:36:42 +0000 (00:36 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Fri, 14 Aug 2009 00:36:42 +0000 (00:36 +0000)
For some reason it was *re-escaping* single-quoted strings; this would lead to corruption in LocalisationUpdate.

includes/ConfEditor.php

index 5ac1d7f..9c8ebb6 100644 (file)
@@ -310,8 +310,7 @@ class ConfEditor {
                                array( '\\\'' => '\'', '\\\\' => '\\' ) );
                if ( $str !== '' && @$str[0] == '"' )
                        // Double-quoted string
-                       return strtr( stripcslashes( substr( $str, 1, -1 ) ),
-                                array( '\'' => '\\\'' ) );
+                       return stripcslashes( substr( $str, 1, -1 ) );
                if ( substr( $str, 0, 4 ) == 'true' )
                        return true;
                if ( substr( $str, 0, 5 ) == 'false' )