Make ORDER BY into key plus value for Database::select call, per bug 9608

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index cdb4998..95396ea 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -321,6 +321,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Removed obsoletes Title::getRelatedCache and Title:touchArray
 * (bug 7285) Check MySQL username length during install
 * (bug 6910) Correct date/time formats in Vietnamese (vi)
+* (bug 9608) Correctly use ORDER BY in dumpLinks.php
 * (bug 9609) Correctly use ORDER BY in SpecialWhatlinkshere.php
 
 == Maintenance ==

diff --git a/maintenance/dumpLinks.php b/maintenance/dumpLinks.php
index cb883e4..2caa873 100644 (file)
--- a/maintenance/dumpLinks.php
+++ b/maintenance/dumpLinks.php
@@ -41,7 +41,7 @@ $result = $dbr->select( array( 'pagelinks', 'page' ),
                'pl_title' ),
        array( 'page_id=pl_from' ),
        'dumpLinks',
-       array( 'ORDER BY page_id' ) );
+       array( 'ORDER BY' => 'page_id' ) );
 
 $lastPage = null;
 while( $row = $dbr->fetchObject( $result ) ) {